Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-posting 'Log from Jenkins Jobs to GitHub Pull Requests as Checks' #6889

Merged
merged 12 commits into from Dec 6, 2023

Conversation

tslmy
Copy link
Contributor

@tslmy tslmy commented Nov 30, 2023

@gounthar kindly invited me to cross-post my blog article here on the Jenkins official blog. This PR drafts up the post.

Question: I can't get the images render correctly locally with make run:

image

I'm quite sure I've followed the path convention in this repo. I think it might be an issue with my local environment, so I opened this PR regardless.

@gounthar
Copy link
Contributor

gounthar commented Nov 30, 2023

Fantastic work!

The images display perfectly on the deployment linked to your last commit: Jenkins to GitHub.

On the topic of images, considering bandwidth costs, we encourage authors to process them with a compression tool like compressor.io. For now, there's no need for images larger than 839 pixels.

I can't recall if this is specified in the contribution guide.

Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this won't work with the typos check until it's corrected. 🤷

content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
Co-authored-by: Bruno Verachten <gounthar@gmail.com>
@tslmy
Copy link
Contributor Author

tslmy commented Nov 30, 2023

Thank you for drawing my attention to the typo. I saw this message:

image

and I thought it was referring to a typo in an existing post. Now I realized that it is comparing total number of typos with the forked branch itself.

@tslmy tslmy requested a review from gounthar November 30, 2023 17:54
Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @tslmy

I need to pause my review, so I wanted to submit the suggestions that I have already gathered. Please let me know if there are any questions or concerns with what I have provided thus far, and I'll be picking things back up tomorrow to finish my review.

content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
tslmy and others added 2 commits November 30, 2023 14:24
Co-authored-by: Kevin Martens <99040580+kmartens27@users.noreply.github.com>
@tslmy
Copy link
Contributor Author

tslmy commented Nov 30, 2023

Thank you @kmartens27 for extensively editing the prose. It's educational to me whose not a native speaker of English. (I tend to mess up plurals for verbs, for one example, as it's a feature that my native language does not have.)

You also made the prose flow more naturally. I really appreciate that.

Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @tslmy! I've finished my review and there are mostly just suggestions for formatting/syntax, so nothing too major. Please let me know if there are any questions or concerns, and apply things as you feel comfortable.

Thanks so much for all of your work and collaboration, and for being open to feedback!!

content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
content/blog/2023/11/2023-11-29-jenkins-to-github.adoc Outdated Show resolved Hide resolved
tslmy and others added 2 commits December 4, 2023 17:13
Co-authored-by: Kevin Martens <99040580+kmartens27@users.noreply.github.com>
@tslmy
Copy link
Contributor Author

tslmy commented Dec 5, 2023

Thank you again @kmartens27 for the detailed review. None of my blog posts had undergone such examination, and I was utterly oblivious about flow issues and syntactical mistakes that I tend to make.

Great to have you proofread my article. Much appreciated!

@kmartens27
Copy link
Contributor

No worries at all @tslmy! I truly appreciate having your blog post contributed. I hope it does not come off as tedious or overbearing, and I hope that my suggestions have been helpful! I want to ensure that what you're sharing is clear and received as expected. Thanks for all of your work on this!

Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot to the author and to the reviewers. 🙏
That's what I call team work! ✋

@kmartens27 kmartens27 merged commit 69b0e82 into jenkins-infra:master Dec 6, 2023
9 checks passed
@tslmy tslmy deleted the lmy branch December 6, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants