New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node tutorial revamp #7095
Node tutorial revamp #7095
Conversation
@kmartens27 : I can't see the difference in the code between https://github.com/gounthar/jenkins.io/blob/node-tutorial-revamp/content/doc/book/installing/_docker-for-tutorials.adoc?plain=1#L28 and https://github.com/gounthar/jenkins.io/blob/node-tutorial-revamp/content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc?plain=1#L173. For the docker documentation, you can copy and paste the code, not for the node tutorial. |
@gounthar from what I've found, it looks like the tutorials page does not have this copy to clipboard functionality overall. I've checked out the other tutorials (Getting Started Tour, current Node, Updated Python & Maven) and none of the tutorials have a copy function within their code blocks. This may have been missed initially when being worked on, but it doesn't seem to have been part of the conversation/work. There could be an argument that for the tutorials, users should be able to follow the instructions and fill in the information manually, but that goes against ease of use. I'm not sure what would prevent the function from being included in those pages/sections, but it does not appear to be available at this time. As noted in the linked PR, Antora does offer this functionality out of the box, so it can be easily addressed when that move occurs. |
…npm.adoc anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @gounthar, everything looks great! I provided some feedback/suggestions but it is more grammatical and structural. The content looks good from here!
content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/build-a-node-js-and-react-app-with-npm.adoc
Outdated
Show resolved
Hide resolved
Thanks a lot for the detailed review, @kmartens27. Co-authored-by: Kevin Martens <99040580+kmartens27@users.noreply.github.com>
This is a follow-up to the "Docker-based Jenkins quickstart examples" 2023 GSoC project.
The goal is to simplify the existing tutorial related to using Docker and eliminate BlueOcean, which is now deprecated.
To achieve this goal, we have a set of Docker images deployed in GHCR, and a repository hosting a docker-compose.yml file.
In this PR, I removed the existing screenshots illustrating BlueOcean and replaced them with screenshots from the Pipeline Graph View plugin.
You can preview the changes at https://deploy-preview-7095--jenkins-io-site-pr.netlify.app/doc/tutorials/build-a-node-js-and-react-app-with-npm/