New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add individual pages for changelog versions #7117
Add individual pages for changelog versions #7117
Conversation
I think that this is a great direction for the changelog pages. I don't have any frequent use case that benefits from multiple changelogs on a single page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a great idea, thanks very much @daniel-beck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
btw. what's the plan with Awestruct => Gatsby+Antora migration? Is this worth implementing in Ruby and rewriting in JS? |
Yup, think so. I am planning to rewrite in JS for the retooling. |
I think this is done enough now so it can be considered to be merged. Thoughts about Former is consistent with the "list" location and makes the individual entry locally a child of the list it appears in. Latter means the prefix for all version pages is the same, for those of us who manually edit URLs. (We may consider generating redirect pages from one to the other too.) |
@daniel-beck would the later make sense where the weekly changelog is already using the |
@kmartens27 Weekly versions get the weekly changelog's |
@daniel-beck yes, that part I understand. I was asking if the URL would end up looking the same for the LTS & Weekly changelogs due to the later's suggested formatting. Would the LTS changelog keep /changelog-stable/ or would it be changed, and if it is changed, how would we differentiate between the LTS & weekly changelogs? |
@kmartens27 The changelog "lists" keep their URLs, nothing that currently exists is being moved. The question is only about whether individual pages for LTS releases have the Current situation
PR as implemented
Suggestion
|
@daniel-beck ah okay that makes much much much more sense, sorry for my confusion! I think keeping it aligned with the current naming convention makes sense. |
Submitted to demonstrate something interesting (IMO) I discussed with @krisstern and @kmartens27 earlier: The ability to generate pages that have no corresponding source file. In this case, Changelog pages for individual Jenkins versions, so that we can replace linking to
/changelog/#v2.440
(including the weird switch to/changelog-old/
) with/changelog/2.440/
etc.While I intend to finish this if it's deemed useful, it's not currently done. WIP:
changelog-stable/
Examples:
https://deploy-preview-7117--jenkins-io-site-pr.netlify.app/changelog/2.440/
https://deploy-preview-7117--jenkins-io-site-pr.netlify.app/changelog-stable/2.440.1/
https://deploy-preview-7117--jenkins-io-site-pr.netlify.app/changelog-stable/2.426.3/