Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 2.68 #973

Merged
merged 2 commits into from
Jul 2, 2017
Merged

Conversation

daniel-beck
Copy link
Contributor

screen shot

Compared to the proposed changelog I trimmed the entries for the remoting update, as they all seemed related -- in fact, the link to the documentation for the first entry mentions the next two as well -- and therefore overly verbose. An (unfinished) intermediate state I tried:

screen shot

This seemed excessive, especially given that AFAIUI nobody gets any of this without reading the linked docs on how to enable it.


While on its own not notable enough for the changelog, the documentation for time zone was not just improved, but now exists for the first time, so calling out the feature's presence in the changelog seemed appropriate.


@oleg-nenashev

@daniel-beck
Copy link
Contributor Author

daniel-beck commented Jul 2, 2017

@oleg-nenashev Overlong commit messages coupled with squashing make it very difficult to find these, as the #1234 isn't visible on a /compare/jenkins-2.67...master URL. As I've asked before, please refrain from squashing unless it's necessary due to a particularly messy history.

Note that I did mention one of these at https://github.com/jenkins-infra/jenkins.io/pull/973/files#diff-5313295831c35cd7b37d630b93438d60R781

@daniel-beck
Copy link
Contributor Author

daniel-beck commented Jul 2, 2017

I see the second one of these similarly not noteworthy, it's improving in robustness, but as this is a user changelog rather than a replacement for the git history, there's no reason to include these unless they fix a bug actually encountered by users.

@oleg-nenashev
Copy link
Contributor

oleg-nenashev commented Jul 2, 2017 via email

@daniel-beck
Copy link
Contributor Author

@oleg-nenashev Done. I went with one entry for both. Does "related to agent connections" capture these correctly?

@oleg-nenashev
Copy link
Contributor

@daniel-beck works for me though it makes people to look into the linked issues. Which is probably fine

@daniel-beck daniel-beck merged commit e8fc408 into jenkins-infra:master Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants