Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publick8s): add nodeSelector to migrated services #4025

Merged
merged 5 commits into from
Jun 1, 2023
Merged

fix(publick8s): add nodeSelector to migrated services #4025

merged 5 commits into from
Jun 1, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jun 1, 2023 •
edited

This PR ensures pods are assigned to x86medium node pool in publick8s, and avoid mixing type of nodes for a same service.

For smaller services, the cheaper arm64small node pool has been privileged, while other has been assigned to the publicpool by default.

Ref: jenkins-infra/helpdesk#3351 & jenkins-infra/helpdesk#3584

@lemeurherve lemeurherve requested a review from a team as a code owner June 1, 2023 14:49
dduportal
dduportal reviewed Jun 1, 2023
View reviewed changes
config/keycloak.yaml Outdated Show resolved Hide resolved
dduportal
dduportal reviewed Jun 1, 2023
View reviewed changes
config/rating.yaml Outdated Show resolved Hide resolved
dduportal
dduportal reviewed Jun 1, 2023
View reviewed changes
config/uplink.yaml Outdated Show resolved Hide resolved
dduportal
dduportal requested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Using the new arm64 pool is under work by @smerle33 , I'm not sure it's wise to use it on all the services. Let's stick to x86
  • We only want to "force" workloads to the x86medium node pool

@lemeurherve @dduportal
Apply suggestions from code review
9d09e73 
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve
lemeurherve commented Jun 1, 2023
View reviewed changes
config/javadoc.yaml Outdated Show resolved Hide resolved
dduportal
dduportal reviewed Jun 1, 2023
View reviewed changes
config/wiki.yaml Outdated Show resolved Hide resolved
@lemeurherve @dduportal
Update config/wiki.yaml
931cd47 
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@lemeurherve lemeurherve mentioned this pull request Jun 1, 2023
Merged
dduportal
dduportal approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lemeurherve lemeurherve mentioned this pull request Jun 1, 2023
Closed
23 tasks
@lemeurherve lemeurherve merged commit 88139fe into jenkins-infra:main Jun 1, 2023
12 checks passed
@lemeurherve lemeurherve deleted the helpdesk3351-fix-nodeselector branch June 1, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja left review comments

@dduportal dduportal dduportal approved these changes

@smerle33 smerle33 Awaiting requested review from smerle33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lemeurherve @dduportal @timja @smerle33 @lemeurherveCB