Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updates.jenkins.io): activate HA for mirrorbits and httpd #5088

Conversation

lemeurherve
Copy link
Member

This PR set the replica count to 2 for the mirrorbits and the httpd subcharts of updates.jenkins.io to activate the High Availability of this service.

As the rsync server won't be requested as much as mirrorbits and Apache, I've kept its replica count to 1.

Ref:

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

2 nitpicks (NOT blocking!)

  1. I would change the title:
  • This change is anew feature as it changes something for end users: requests are spread across replicas and the availability is increased
  • The "component" should be publick8s or eventually publick8s/updates.jenkins.io to help the reviewer (or us in 3 months) to immediately locate which cluster was impacted. This one is a nit because we do not have a formal convention.
  1. The helmfile diff only shows a Pod Disruption Budget for mirrorbits but not for the httpd component: worth checking once merged and deployed successfully (maybe it already exists, or maybe the httpd chart does not define a PDB when replicating). Might be worth checking along with get.jenkins.io

@dduportal dduportal merged commit 62f943f into jenkins-infra:main Mar 27, 2024
8 checks passed
@dduportal
Copy link
Contributor

LGTM!

2 nitpicks (NOT blocking!)

1. I would change the title:


* This change is  anew feature as it changes something for end users: requests are spread across replicas and the availability is increased

* The "component" should be `publick8s` or eventually `publick8s/updates.jenkins.io` to help the reviewer (or us in 3 months) to immediately locate which cluster was impacted. This one is a nit because we do not have a formal convention.


2. The helmfile diff only shows a Pod Disruption Budget for `mirrorbits` but not for the `httpd` component: worth checking once merged and deployed successfully (maybe it already exists, or maybe the httpd chart does not define a PDB when replicating). Might be worth checking along with get.jenkins.io

Issue: jenkins-infra/helm-charts#1109

@lemeurherve lemeurherve deleted the helpdesk2649-updates-jenkins-io-httpd-ha branch March 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants