Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli) fix JDK tool manifests #5171

Merged
merged 1 commit into from Apr 24, 2024

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Apr 24, 2024

This PR is related to jenkins-infra/helpdesk#4058. It ensures that updatecli properly updates the JDK tools on infra.ci.jenkins.io:

It also closes #4998 (superseds).

@dduportal dduportal marked this pull request as ready for review April 24, 2024 18:42
@dduportal dduportal requested a review from a team as a code owner April 24, 2024 18:42
- Remove commented sections on JDK17 and JDK21
- Uses the Temurin API to retrieve the download URL for each platform
- Ensure that no hard failure happens using condition and an "echo" fallback on sources

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor Author

The updatecli checks looks good:

[2024-04-24T18:49:55.231Z] Run Summary
[2024-04-24T18:49:55.231Z] ===========
[2024-04-24T18:49:55.231Z] Pipeline(s) run:
[2024-04-24T18:49:55.231Z]   * Changed:	3
[2024-04-24T18:49:55.231Z]   * Failed:	0
[2024-04-24T18:49:55.231Z]   * Skipped:	0
[2024-04-24T18:49:55.231Z]   * Succeeded:	44
[2024-04-24T18:49:55.231Z]   * Total:	47

=> The 3 changed elements are JDK11 (URL update to encoded ones), JDK17 and JDK21

@dduportal dduportal merged commit 0001215 into jenkins-infra:main Apr 24, 2024
6 of 7 checks passed
@dduportal dduportal deleted the chore/updatecli/jdk-tools branch April 24, 2024 19:36
@dduportal dduportal mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant