Remove forceAci - all usages updated

[slide]

No description provided.

[dwnusbaum]

It looks like the only uses of forceAci are in email-ext and azure-keyvault, although various plugins have copied the contents of buildPlugin.groovy into their Jenkinsfile, see this search. If we update those repositories we can just delete the parameter and its documentation entirely.

[jglick]

pipeline-library/vars/buildPlugin.groovy

Lines 18 to 19 in 3382e5e

	def forceAci = params.containsKey('forceAci') ? params.forceAci : false
	def useAci = params.containsKey('useAci') ? params.useAci : forceAci

[slide]

It looks like the only uses of forceAci are in email-ext and azure-keyvault, although various plugins have copied the contents of buildPlugin.groovy into their Jenkinsfile, see this search. If we update those repositories we can just delete the parameter and its documentation entirely.

I can update email-ext easily (I maintain that one). I'll file a PR against azure-keyvault as well.

[slide]

email-ext is updated (jenkinsci/email-ext-plugin@a5757a6), PR for azure-keyvault submitted (jenkinsci/azure-keyvault-plugin#62)

[timja]

Merged azure-keyvault, I think we were using it for testing windows ci 🤷
or an ACI fix =/

[slide]

I'm submitting PR's to the projects that copied the contents of buildPlugin. It's mostly the warnings-ng and it's dependencies. I need to compare what they have in buildPlugin vs what we have in the global library to see what they are needing so we can move them to use buildPlugin from the global library.

[timja]

It's this PR #121 they need

[slide]

Good point...

[dwnusbaum]

Thanks!