Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buildDockerAndPublishImage): correct git credential config to tag on Windows #395

Merged
merged 16 commits into from
May 31, 2022
Merged

fix(buildDockerAndPublishImage): correct git credential config to tag on Windows #395

merged 16 commits into from
May 31, 2022

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented May 31, 2022 •
edited

By setting Git Credential Manager store to plaintext and by disabling its interactive prompt, we avoid the following error when trying to push git tag on Windows:

fatal: Unable to persist credentials with the 'wincredman' credential store.

Additionally:

  • Concurrent builds are now disabled on primary branch to avoid tag conflicts between successive builds.
    Alas, this won't be enough in case we're activating semver for images built in parallel like in https://github.com/jenkins-infra/docker-inbound-agents/blob/main/Jenkinsfile_k8s, and additional PR to include the image name in the tag is needed & incoming
  • The next version is shown even on PR
  • The default gitCredential to use is set to the Github App github-app-infra

Related: jenkins-infra/helpdesk#2873

@lemeurherve lemeurherve mentioned this pull request May 31, 2022
Closed
@lemeurherve lemeurherve changed the title fix: credential.helper again fix(buildDockerAndPublishImage): correct git credential config to be abble to tag on Windows May 31, 2022
@lemeurherve lemeurherve marked this pull request as ready for review May 31, 2022 11:23
@lemeurherve lemeurherve requested a review from a team as a code owner May 31, 2022 11:23
@lemeurherve lemeurherve changed the title fix(buildDockerAndPublishImage): correct git credential config to be abble to tag on Windows fix(buildDockerAndPublishImage): correct git credential config to tag on Windows May 31, 2022
@lemeurherve lemeurherve mentioned this pull request May 31, 2022
Closed
lemeurherve pushed a commit to lemeurherve/pipeline-library that referenced this pull request May 31, 2022
@lemeurherveCB
feat: add multipleSemverImagesBuild param
ecebc3b 
Close jenkins-infra#396
Follow-up of jenkins-infra#395
lemeurherve pushed a commit to lemeurherve/pipeline-library that referenced this pull request May 31, 2022
@lemeurherveCB
feat: add multipleSemverImagesBuild param
ece93f7 
Close jenkins-infra#396
Follow-up of jenkins-infra#395
lemeurherve pushed a commit to lemeurherve/pipeline-library that referenced this pull request May 31, 2022
@lemeurherveCB
feat: add multipleSemverImagesBuild param
6546be9 
Close jenkins-infra#396
Follow-up of jenkins-infra#395
dduportal
dduportal approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lemeurherve lemeurherve merged commit 6a8958a into jenkins-infra:master May 31, 2022
@lemeurherve lemeurherve deleted the fix-credential-helper-helpdesk-2873 branch May 31, 2022 15:44
lemeurherve pushed a commit to lemeurherve/pipeline-library that referenced this pull request May 31, 2022
@lemeurherveCB
feat: add multipleSemverImagesBuild param
d2e469a 
Close jenkins-infra#396
Follow-up of jenkins-infra#395
@lemeurherve lemeurherve mentioned this pull request May 31, 2022
Merged
dduportal added a commit that referenced this pull request May 31, 2022
@lemeurherve @dduportal
feat: add multipleSemverImagesBuild param (#399)
3824807 
Close #396
Follow-up of #395

Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@lemeurherve lemeurherve mentioned this pull request May 31, 2022
Closed
lemeurherve added a commit to lemeurherve/pipeline-library that referenced this pull request Jun 1, 2022
@lemeurherve @lemeurherveCB
fix(buildDockerAndPublishImage): correct git credential config to tag…
6d48a4e 
… on Windows (jenkins-infra#395)
lemeurherve added a commit to lemeurherve/pipeline-library that referenced this pull request Jun 1, 2022
@lemeurherve @dduportal @lemeurherveCB
feat: add multipleSemverImagesBuild param (jenkins-infra#399)
a4dc5ee 
Close jenkins-infra#396
Follow-up of jenkins-infra#395

Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
smerle33 pushed a commit to smerle33/pipeline-library that referenced this pull request Jan 16, 2024
@lemeurherve @smerle33
fix(buildDockerAndPublishImage): correct git credential config to tag…
68b8560 
… on Windows (jenkins-infra#395)
smerle33 pushed a commit to smerle33/pipeline-library that referenced this pull request Jan 16, 2024
@lemeurherve @dduportal @smerle33
feat: add multipleSemverImagesBuild param (jenkins-infra#399)
7693b80 
Close jenkins-infra#396
Follow-up of jenkins-infra#395

Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lemeurherve @dduportal @lemeurherveCB