Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): add toleration to use infracipool #655

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

lemeurherve
Copy link
Member

To avoid cutting off the branch we're sitting on when modifying privatek8s node pools (ex: jenkins-infra/azure#329 and its infra.ci.jenkins.io job which ran on the "linuxpool" node pool impacted by this change), this PR sets a toleration so terraform jobs will run on infracipool only.

@lemeurherve lemeurherve requested a review from a team as a code owner April 21, 2023 15:40
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dduportal dduportal enabled auto-merge (squash) April 21, 2023 15:42
@dduportal dduportal merged commit 8f53e9b into jenkins-infra:master Apr 21, 2023
3 checks passed
alextu added a commit to alextu/pipeline-library that referenced this pull request May 2, 2023
* origin/master:
  Bump `hashicorp-tools` docker image to 0.5.163 (jenkins-infra#659)
  fix(buildPlugin) ensure the custom label is passed to node when adding custom platform (jenkins-infra#658)
  feat(buildPluginWithGradle) Add quality checks (jenkins-infra#652)
  hotfix(terraform) add spot toleration
  hotfix(terraform) add nodeselector
  Update updatecli version to v0.49.2 (jenkins-infra#657)
  fix(terraform): add toleration to use infracipool (jenkins-infra#655)
  Bump `hashicorp-tools` docker image to 0.5.162 (jenkins-infra#651)
@lemeurherve lemeurherve deleted the terraform-toleration branch June 1, 2023 13:28
smerle33 pushed a commit to smerle33/pipeline-library that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants