feat(buildDockerAndPublishImage): allow to specify a target when using docker bake #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
added a commit
to jenkins-infra/docker-jenkins-weekly
that referenced
this pull request
Jan 10, 2024
lemeurherve
force-pushed
the
helpdesk3887-feat-build-bake-target
branch
from
e99e4aa
to
6be0c7c
Compare
lemeurherve
added a commit
to jenkins-infra/docker-jenkins-weekly
that referenced
this pull request
Jan 10, 2024
|
Tested with success in jenkins-infra/docker-jenkins-weekly#1467:
|
dduportal
reviewed
Jan 11, 2024
dduportal
previously requested changes
Jan 11, 2024
There was a problem hiding this comment.
(edited after team discussion)
This PR also fixes the fact that before this change when using docker bake, cst tests are executed only on the image with the latest tag instead of testing all* built targets.
This is a distinct change which need to be discussed as there were reason for not doing it.
Can you remove it from this PR please as it is a blocker from my point of view.
After discussion:
- I misunderstood: the changes on "tests" in this PR not only are required, but are also only scoped to choose the proper local image to build. The PR body explains it carefully, I misread the asterisk, nevermind my remark
- Although we want to remove the naming constraint "image tag" <-> "target" (ref. Test jenkins-infra/pipeline-library#822 docker-jenkins-weekly#1467)
lemeurherve
added a commit
to jenkins-infra/docker-jenkins-weekly
that referenced
this pull request
Jan 11, 2024
…ne-library#822" This reverts commit e8d6d02.
Addressed in jenkins-infra/docker-jenkins-weekly@814c2a0 by retrieving the tag of the selected target(s), with the Tested successfully in jenkins-infra/docker-jenkins-weekly#1467 from where I removed the tags modifications to keep only the test of this PR:
|
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
smerle33
pushed a commit
to smerle33/pipeline-library
that referenced
this pull request
Jan 16, 2024
…g docker bake (jenkins-infra#822) * feat(buildDockerAndPublishImage): allow to specify a target when using docker bake * allow cst to test a specific tag of an image * allow cst to test a specific tag of an image * Update vars/buildDockerAndPublishImage.txt Co-authored-by: Damien Duportal <damien.duportal@gmail.com> --------- Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
dockerBakeTargetparameter to thebuildDockerAndPublishImagefunction to allow specifying a target when using docker bake.This PR also fixes the fact that before this change when using docker bake, cst tests are executed only on the image with the
latesttag instead of testing all* built targets.Ref:
*: with a platform corresponding to the architecture of the machine executing the tests.