[INFRA-2118] Add function to run JMH benchmarks #91
Conversation
vars/runBenchmarks.groovy
Outdated
| * @since TODO | ||
| */ | ||
| def call(String artifacts = null) { | ||
| // TODO: Use Lockable Resources plugin |
There was a problem hiding this comment.
I am not sure we can merge it without it. Maybe it makes sense to create an INFRA ticket to @olblak to get it set up. Maybe 2 parallel runs is a good limit for now.
There was a problem hiding this comment.
There was a problem hiding this comment.
the lockable plugin is already installed
There was a problem hiding this comment.
@olblak We need you to create a resource that we can use for throttling benchmarks running on highmem nodes.
There was a problem hiding this comment.
so something like lock('runBenchmarks') {
}
should be fine
vars/runBenchmarks.groovy
Outdated
| } | ||
|
|
||
| stage('Archive reports') { | ||
| if (artifacts != null) { |
There was a problem hiding this comment.
artifacts is a parameter to the function
vars/runBenchmarks.groovy
Outdated
|
|
||
| stage('Archive reports') { | ||
| if (artifacts != null) { | ||
| archiveArtifacts artifacts: artifacts |
There was a problem hiding this comment.
Would it also make sense to generate a http://jmh.morethan.io/ viewer link and put it to the console log for now?
|
Yes, that would be great!
…On Tue, 11 Jun 2019, 18:30 Olblak, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In vars/runBenchmarks.groovy
<#91 (comment)>
:
> @@ -0,0 +1,29 @@
+#!/usr/bin/env groovy
+
+/**
+ * Run JMH benchmarks and archives results
+ * @param artifacts archive these JMH reports
+ * @SInCE TODO
+ */
+def call(String artifacts = null) {
+ // TODO: Use Lockable Resources plugin
so something like lock('runBenchmarks') {
}
should be fine
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#91?email_source=notifications&email_token=ACXQV35GNEGAXRAVX4OXV4LPZ6OYRA5CNFSM4HWQ6DY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3FJMTY#discussion_r292440910>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACXQV3YINY4EGDHYXONOWQ3PZ6OYRANCNFSM4HWQ6DYQ>
.
|
|
" IMHO we can ship it once JTH and Plugin POM patches are out" @olblak They are not :) No worries, we will get there soon |
Uses the added Maven profile from jenkinsci/plugin-pom#206 and jenkinsci/jenkins-test-harness#135
and adds a utility function to run benchmarks in Jenkinsfiles.
@oleg-nenashev @runzexia @Supun94