Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #102 where the warning icon is missing #103

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Jan 23, 2020

Related to issue
Fixes #102

Summary of this pull request: Restores the badge box being visible

image

@halkeye halkeye requested a review from timja January 23, 2020 21:40
@halkeye halkeye requested a review from a team as a code owner January 23, 2020 21:40
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ I thought there was a bigger issue, tested locally.
Modal isn't that nice, but same as before I assume

@timja
Copy link
Member

timja commented Jan 23, 2020

Hmm, it's missing a pointer / hand click to show it's clickable, was it like that before?

(tbh I don't think it's obvious this is clickable anyway and I don't like the UX of this feature)

@halkeye
Copy link
Member Author

halkeye commented Jan 23, 2020

Modal isn't that nice, but same as before I assume

i think the modal used to be bigger. I switched it to bootstrap modal from the home brewed one

Hmm, it's missing a pointer / hand click to show it's clickable, was it like that before?

As far as I can tell it was like that. I can add cursor: pointer easy. Agreed UX sucks

@halkeye
Copy link
Member Author

halkeye commented Jan 23, 2020

Gonna merge, we can fix css later

@halkeye halkeye merged commit 195d801 into jenkins-infra:master Jan 23, 2020
@halkeye halkeye deleted the fix-102-missing-warning branch January 23, 2020 22:09
@daniel-beck
Copy link
Contributor

i think the modal used to be bigger. I switched it to bootstrap modal from the home brewed one

Yeah, filled the entire screen, was pretty horrible for how little content it contained.

This one is much nicer, but perhaps the titles could be a bit smaller? Seems excessive.

@halkeye
Copy link
Member Author

halkeye commented Jan 26, 2020

@daniel-beck I can certainly make it wider, but it might be worth getting UX guild's opinion (and a new issue)

@halkeye halkeye added the bug label Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin site no longer shows active security warnings
3 participants