New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning boxes for plugins which are deprecated or up for adoption #130
Add warning boxes for plugins which are deprecated or up for adoption #130
Conversation
Looks like some space is needed below the dependencies? or not showing the warning as full width? |
Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>
I can add some. I am not a designer, so I will be happy to address any feedback regarding the layout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this very much. I do not have design or layout skills. I highly approve of the concept underlying these additions to the plugins.jenkins.io site and am happy to have others offer styling or layout improvements.
Hmm does it pull labels from both the update center and github? |
@Casz GitHub topics are being processed by the update center in jenkins-infra/update-center2#316 , and the Plugin site receives an aggregated list |
Co-Authored-By: Ullrich Hafner <ullrich.hafner@gmail.com>
FWIW I intend to continue the work on @Casz's jenkinsci/jenkins#4073 possibly in a collaboration with him, now that my previous project is merged, just haven't heard back on Gitter yet. |
I don't use gitter actively. I most reachable on GitHub. I'll look at it later. |
jenkins-infra/jenkins.io#2875 documents the new process for adoption and deprecation |
background-color: #fcf8e3; | ||
color: #a48d62; | ||
border-color: #faebcc; | ||
margin-bottom: 5px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you would be better served adding a margin-top: 10px
and adding a margin-top: 10px
to content
class
plugin-site/src/templates/plugin.jsx
Line 68 in 5e62e6f
{plugin.wiki.content && <div className="content" dangerouslySetInnerHTML={{__html: plugin.wiki.content}} />} |
(feel free to mess around with the pixel number)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to rework the dependency and maintainer listing soon, so I do not worry that much about margins for now. I would suggest doing it as a separate change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine 😅
Co-Authored-By: Joseph Petersen <josephp90@gmail.com>
I will merge it to get the ball rolling. Thanks everyone for the reviews! |
Follow-up to the discussion in https://groups.google.com/forum/#!topic/jenkinsci-dev/UoEqG5AaWJU
. This pull request add warning boxes for plugins which have
deprecated
,adopt-this-plugin
andadopt-me
labels. Colors have been taken from standard Jenkins warning boxes. Sorry about my layout MADSKILLZ, feel free to rework.Text for the deprecated plugins has been taken from jenkinsci/jenkins#4073 by @Casz. Unfortunately deprecated plugins do not always reference the documentation, the guideline is quite vague at the moment.