Remove Jira table, improve side panel links #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halkeye
reviewed
Apr 20, 2020
| @@ -96,8 +96,8 @@ function PluginPage({data: {jenkinsPlugin: plugin}}) { | |||
| <a href={plugin.wiki.url} target="_wiki">Jenkins Wiki</a> | |||
| {' the '} | |||
| <a href="https://groups.google.com/forum/#!msg/jenkinsci-dev/lNmas8aBRrI/eL3u7A6qBwAJ" rel="noopener noreferrer" target="_blank">read-only state</a> | |||
| {'. We recommend moving the plugin documentation to GitHub, see the guidelines '} | |||
| <a href="https://jenkins.io/blog/2019/10/21/plugin-docs-on-github/" rel="noopener noreferrer" target="_blank">here</a> | |||
There was a problem hiding this comment.
so 👍, "here" is such bad practice.
halkeye
reviewed
Apr 20, 2020
| @@ -31,6 +31,8 @@ function getContentFromConfluencePage(url, content) { | |||
|
|
|||
| // Remove any table of contents | |||
| $('.toc').remove(); | |||
| // remove jira issue table | |||
| $('.jira-table.conf-macro.output-block').remove(); | |||
There was a problem hiding this comment.
Could anyone use jira-table in some other context where it makes sense to keep it? I wasn't 100% sure.
There was a problem hiding this comment.
yea, more specific is good since its auto generated anyways.
There was a problem hiding this comment.
I'm not sure we can easily do it on plugins-api, but since all wiki fetching is done by plugin-site for now, i'm happy with this.
halkeye
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 minor SEO related fixes