Make popularity graph start at y=0 #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
commented
Oct 30, 2020
| @@ -13,12 +13,11 @@ const calculateHeight = (total) => { | |||
| }; | |||
|
|
|||
| const calculateMinMax = (data) => { | |||
| const minValue = Math.min(...data); | |||
| const maxValue = Math.max(...data); | |||
| // calculate a dynamic value to center the graph | |||
There was a problem hiding this comment.
We're no longer centering things here, so I'm not sure how well this comment applies anymore.
|
The "worst case" for the range algorithm is when the max install count is just over a power of 10. Then the top of the graph is 2x that power of 10, like for
The current behavior isn't great either though (IMO), I would even argue there's an improvement:
|
|
This is what I was suggesting in the original PR but I thought I was in the minority on that. Thanks for the PR! |
|
@zbynek Thanks, I appreciate the agreement and merge – although it might be better to give potentially controversial PRs like this a little more time to collect feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #402 to always start the graph at y=0. Showing a narrower range is misleading at a glance. Even if it shows small differences more clearly, the downside doesn't seem worth it.
FYI @ARUNMOHANRAJ471
Example: Showing rapidly changing popularity
While both https://plugins.jenkins.io/trilead-api/ and https://plugins.jenkins.io/okhttp-api/ gained popularity, the relative gains are very different, so should result in different graphs.
Before
After
Example: Showing fairly unchanging popularity
Additionally, this will now not over-emphasize fairly insignificant differences in reported installation counts.
Before
After