Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove red (required) from mandatory dependencies #61

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Sep 11, 2019

It is the default, and most common, scenario for a plugin-to-plugin dependency to be required. There is no reason to highlight this in red as if it were an error the user must pay attention to. In fact we should not even be displaying (required) at all; it is just visual noise.

@jglick jglick changed the title Remove red coloring from (required) Remove red (required) Sep 11, 2019
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's keep it simple

@oleg-nenashev oleg-nenashev changed the title Remove red (required) Remove red (required) from mandatory dependencies Sep 17, 2019
@oleg-nenashev oleg-nenashev merged commit 5beac9c into jenkins-infra:develop Sep 17, 2019
@jglick jglick deleted the required-red branch September 19, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants