Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synonyms for p4 and perforce #618

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Add synonyms for p4 and perforce #618

merged 2 commits into from
Apr 1, 2021

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Apr 1, 2021

As reported on irc:

@omehegan: @halkeye: I just noticed that when you search the plugins page for 'perforce' all the results are as if I searched for 'performance.' neither of the perforce plugins show up :) https://plugins.jenkins.io/ui/search?query=perforce
@halkeye: autojack: https://github.com/jenkins-infra/update-center2/blob/1690b80d6a92489c1be9ba51105c47ba4f3e5d9d/resources/artifact-ignores.properties#L319 short version is perforce is blacklisted
@omehegan: got it. but if someone wants to find the p4 plugin, they have to know to search for p4?
it just seems like searching for perforce should at least return the p4 plugin.
@halkeye: oh interesting, we ended up disabling searching the body of the readme file
@halkeye: okay i can add it as a synonym, it'll find perforc and perforce, but not perfor which feels right
@omehegan: sounds good! just one of those weird gotchas.
@omehegan: I was looking at the results, very confused. "This is almost, but not quite, exactly what I wasn't looking for."

I like everything config inside the code, but that does mean that anything we do in the UI will get overridden, so we'd have to decide now if we want synonyms in there

@halkeye halkeye requested a review from a team as a code owner April 1, 2021 04:28
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a great idea.

@halkeye halkeye merged commit 40604ad into master Apr 1, 2021
@halkeye halkeye deleted the halkeye-patch-1 branch April 1, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants