[WEBSITE-405] Use plugin-specific title and description in response metadata

[timja]

Downstream of jenkins-infra/jenkins.io#2674

Related to issue # WEBSITE-405

Summary of this pull request:
SEO fixes to use specific title, and description

cc @halkeye @zbynek @oleg-nenashev

[oleg-nenashev]

This description does not help in the case of plugins. I believe that almost all plugins already set a kind of description, but we might want to have a somethinf more explicit. Not a blocker

[timja]

The description comes from the index.jelly so it's required AFAIK, this is used on pages that aren't plugins, i.e. at least the home page.

Happy to reword it, but this is what it was before

[oleg-nenashev]

I will try to land it today

[zbynek]

@timja @oleg-nenashev does title change on navigation for you?

[timja]

@timja @oleg-nenashev does title change on navigation for you?

no it doesn't struggling to fix it though,
figured out why I was getting so stumped earlier though, any errors in server.js were getting swallowed

[timja]

@timja @oleg-nenashev does title change on navigation for you?

Fixed

[zbynek]

now the title is updated on navigation to a plugin, but not when you navigate back with the "fid plugins" link

[timja]

now the title is updated on navigation to a plugin, but not when you navigate back with the "fid plugins" link

Seems to work for me?
Could you please upload a gif or be more specific on URLs / steps?

i.e. I did:

export HEADER_FILE=http://0.0.0.0:4242/template/index.html
yarn server

open http://localhost:5000

• type slack, enter
• Click Slack Notification
• See title updated
• Click Find plugins
• See title updated
• Click cucumber-slack-notifier
• See title updated

[zbynek]

• run

HEADER_FILE=https://gist.githubusercontent.com/zbynek/816b7cb8a613a4e1fe4a3ba5c160dab8/raw yarn server

• open http://localhost:5000/git
• click Find plugins -> title is still Git, expected Jenkins plugins
• click any plugin on index page -> title is OK
• click Find plugins again -> title reverts to git

If I start by visiting the index page, it works

[timja]

• run

HEADER_FILE=https://gist.githubusercontent.com/zbynek/816b7cb8a613a4e1fe4a3ba5c160dab8/raw yarn server

• open http://localhost:5000/git
• click Find plugins -> title is still Git, expected Jenkins plugins
• click any plugin on index page -> title is OK
• click Find plugins again -> title reverts to git

If I start by visiting the index page, it works

Fixed thanks for the testing

[zbynek]

@timja looks good now 🎉

[oleg-nenashev]