-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CSS (remove main.module.css) #675
Conversation
hrmmmmm, at some point when I created #80, I was really annoyed at the !importants, and eventually I came around on the css modules. I'm absolutely cool with this PR once its updated with latest master, but we should also decide if we want to do modules or not. There's 3 other files that I could pull out in a followup PR. https://github.com/jenkins-infra/plugin-site/blob/master/src/components/Checksum.module.css The nice thing about css modules is that they are contained and a module doesn't care where its used, it just has css applied. But at the same time, it makes it harder to see whats going on. So feelings? |
a couple minor nitpicky stuff, not blocking the {''} to "" stuff, i just feel its cleaner |
Co-authored-by: Gavin Mogan <github@gavinmogan.com>
Co-authored-by: Gavin Mogan <github@gavinmogan.com>
I think modules are fine if they have clearly defined responsibilities, i.e. classes defined in the module are not present in base.css and the module dos not contain classes for unrelated components. Maybe we could do modules for new components and keep the non-module CSS files for old stuff. Also we're loading bootstrap by default, so we can leverage some of the classes it defines like |
Fixes #80 (see issue for details)