Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile layout improvements #678

Merged
merged 2 commits into from
May 26, 2021
Merged

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented May 25, 2021

Related to issue #273, #483

Summary of this pull request:

  • swap metadata and description on mobile
  • remove the archives link (duplicates "releases" tab)
  • make list view for search more responsive
  • remove table view for search (nearly identical to list view)
  • fix ranges in pagination (should be "1 to 50", "51 to 100", not "0 to 50", "50 to 100")

@zbynek zbynek requested a review from a team as a code owner May 25, 2021 06:11
@timja
Copy link
Member

timja commented May 25, 2021

screenshots?

@zbynek
Copy link
Contributor Author

zbynek commented May 25, 2021

Search page before:

image

after:

image

Plugin page (only after)

image

image

@timja
Copy link
Member

timja commented May 25, 2021

Failing for 'string.prototype.trimend not accessible from es-abstract'

@zbynek zbynek marked this pull request as draft May 25, 2021 09:59
@zbynek
Copy link
Contributor Author

zbynek commented May 25, 2021

@timja thanks for reviewing. I realized it would make sense to keep the heading on top, so I'll extend this PR a bit. It might be good to get jenkins-infra/jenkins.io#4382 merged first.

@zbynek
Copy link
Contributor Author

zbynek commented May 25, 2021

... the heading is now moved to top level, so it should show OK for both mobile and desktop (screenshots updated). The gutter class is removed here completely to make this independent on jenkins-infra/jenkins.io#4382 (changing gutter padding was needed to align stuff better on mobile).

@zbynek zbynek marked this pull request as ready for review May 25, 2021 14:32
@zbynek
Copy link
Contributor Author

zbynek commented May 26, 2021

@halkeye ok to merge?

@halkeye
Copy link
Member

halkeye commented May 26, 2021

I'm def behind on reviewing sorry, I saw the pagination change and got scared and figured i'd follow up, then got distracted.

Did you test it with an algoila key? I've just been setting up free projects cause the whole setup is defined via code it'll auto populate for you.

Layout wise, your way better at it than me, so i totally trust you on that.

@zbynek
Copy link
Contributor Author

zbynek commented May 26, 2021

@halkeye the pagination is just a display thing, the API calls and plugin tiles are the same, just the heading changed from "0 to 2" to "1 to 2" here

image

Copy link
Member

@halkeye halkeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh its happening on prod too, so yea good to go
it took a bunch of data massaging to get the two to work the same way so i am concerned. We should probably delete the non algoila code eventually.

@zbynek zbynek merged commit f345a4c into jenkins-infra:master May 26, 2021
@zbynek zbynek deleted the mobile-layout branch May 26, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants