-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile layout improvements #678
Conversation
screenshots? |
Failing for 'string.prototype.trimend not accessible from es-abstract' |
@timja thanks for reviewing. I realized it would make sense to keep the heading on top, so I'll extend this PR a bit. It might be good to get jenkins-infra/jenkins.io#4382 merged first. |
... the heading is now moved to top level, so it should show OK for both mobile and desktop (screenshots updated). The |
@halkeye ok to merge? |
I'm def behind on reviewing sorry, I saw the pagination change and got scared and figured i'd follow up, then got distracted. Did you test it with an algoila key? I've just been setting up free projects cause the whole setup is defined via code it'll auto populate for you. Layout wise, your way better at it than me, so i totally trust you on that. |
@halkeye the pagination is just a display thing, the API calls and plugin tiles are the same, just the heading changed from "0 to 2" to "1 to 2" here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh its happening on prod too, so yea good to go
it took a bunch of data massaging to get the two to work the same way so i am concerned. We should probably delete the non algoila code eventually.
Related to issue #273, #483
Summary of this pull request: