Adds a dev section to the bottom of the dependency tab #712
Conversation
zbynek
force-pushed
the
dev-info
branch
2 times, most recently
from
84bc50d
to
9c839a6
Compare
src/components/MavenDependency.jsx
Outdated
| and the following depndency snippet: | ||
| </> | ||
| </p>} | ||
| <pre> |
There was a problem hiding this comment.
we have the plugin to make things click to copy if its useful here. I was going to say I don't know who would find the maven coords useful till I saw the jira ticket.
src/templates/plugin.jsx
Outdated
| </div> | ||
| <div className="sidebarSection"> | ||
| <h5>Links</h5> | ||
| {plugin.scm && plugin.scm.link && <div className="label-link"><a href={plugin.scm.link}>GitHub</a></div>} | ||
| {plugin.scm && plugin.scm.link && <div className="label-link"><a target="_blank" href={plugin.scm.link} rel="noreferrer">GitHub</a></div>} |
There was a problem hiding this comment.
I'm generally not a fan of forcing new tabs to happen, takes away the agency from the user. Is there a request for new tab, or just a preference?
|
Couple small notes but looks good to me. |
|
@daniel-beck any 👍/👎 on including the Maven dependency? It was requested in a comment, so it extends the scope of your ticket. Hopefully it's hidden well enough not to bother majority of users and still provides some value for plugin devs. |
|
I love including the maven dependency, I think I would use it a lot |
zbynek
force-pushed
the
dev-info
branch
2 times, most recently
from
d0309ca
to
af6ce07
Compare
|
@halkeye screenshots updated to show the clipboard copy buttons. It's now extracted to a component, so the release tab changed slightly as well: |
Thats really awesome. I try to (remember to) make things components as much as possible so its easier to refactor and improve. This is a great improvement |
|
Ironically this will be least useful for plugins that have tons of dependencies already, because the bottom of that page is very far down 😄 Perhaps this could be inserted at the top of the "Dependent plugins" section, which is typically the long section for popular dependencies (especially detached plugins), and also makes sense semantically ("How to add a plugin to this section")? |
|
@daniel-beck thanks for the suggestion, I moved the dependencies up. |
|
@daniel-beck OK to merge? |
halkeye
changed the title
Related to issue https://issues.jenkins.io/browse/WEBSITE-386
Adds a dev section to the bottom of the dependency tab:
Plugin in BOM
Standard plugin
... and a link to detailed usage stats in the sidebar
Same for all plugins
CC @daniel-beck