Convert plugins.jenkins.io to a static compiled html site #76
Conversation
|
@halkeye Interesting work, the site looks promising but what does this mean "staticly compile?" Does this remove the need for the API server behind the scenes? |
|
It uses the API server for search, and the initial compiling. The search could easily be switched away from API server. I think lots of the API server functionality could get moved to update center. |
|
@halkeye Yeah, I have long thought about just removing the API server from the equation and just grabbing the update center for the page to use at runtime. The Update Center JSON is a little fat, but it would allow plugins.jenkins.io to be run off github pages entirely |
It doesn't have to have the content inside the update center json, it could easily be seperate files Then different things could start consuming more and more of it, like inside jenkins could show the readme as an iframe or something.
I'm pretty sure it would only take me a couple hours at most to remove API from runtime for search, i did it because I thought "relevance" search was something special. |
… lifecycle, and hard to style
There was a problem hiding this comment.
:o 156 file changes
On overall it's already a major improvement, removing ci.jenkins.io dependency and being able to search for plugin information on my phone is already awesome. I am still evaluating Netlify instead of azure.
I still have to give another review on this PR
| environment { | ||
| DISABLE_SEARCH_ENGINE = "true" // for the test site | ||
| GATSBY_CONFIG_SITE_METADATA__URL = "https://jenkins-plugins.g4v.dev/" | ||
| GATSBY_CONFIG_SITE_METADATA__SITE_URL = "https://jenkins-plugins.g4v.dev/" |
There was a problem hiding this comment.
I guess this url will have to be updated
There was a problem hiding this comment.
This is only the "test" server (in comments). Its running on my jenkins instance, everywhere else will just do the regular build.
Dockerfile
Outdated
| CMD yarn server | ||
|
|
||
| EXPOSE 5000 | ||
| # FROM nginx:1.17.6 |
There was a problem hiding this comment.
is the intention to use nginx image? what's the reason for this comment being here?
There was a problem hiding this comment.
left behind probably. the gatsby image is way faster than stock nginx, and i still think cdn > docker.
|
The homepage doesn't look great on my widescreen monitor: Plugins index off center,
for comparison existing one:
|
|
Is the text too far to the left on desktop now?
|
|
The CSS seems to be missing for the pointer on the search page and the border highlight on hover is missing, https://jenkins-plugins.g4v.dev/ui/search?query=azure static site: prod: little hard to tell in the screenshot but their should be a "hand" pointer to indicate that the tile is clickable, and the border in the previous site was highlighted to further indicate which one would be clicked on I guess |
…r over and click individual items
thats not very actionable. Who should answer that? I can certainly give it more padding, but how much is good? At some point maybe we should involve @josephbrueggen/ux sig |
… be layed out better for mobile
…t on ci.gavinmogan, Deploy prod on infra
|
Okay, I think I've handled all the issues. Its getting super hard to keep track of change requests. |
|
Build failed; the context from the latest run is: Expand to view |
|
Build failed; the context from the latest run is: Expand to view |
Jenkinsfile
Outdated
| sh "docker push ${imageName()}:${imageTag()}" | ||
| } | ||
| /* -> https://github.com/Azure/blobxfer | ||
| Require credential 'JAVADOC_STORAGEACCOUNTKEY' set to the storage account key */ |
There was a problem hiding this comment.
Credential name needs updating or comment removed
There was a problem hiding this comment.
.. i was very confused, I remember specifically removing that line and didn't think i committed it.
🤷♂ 🚢 |
Changes
Outstanding issues
Jenkins Plugins | Jenkins Pluginsin various placesDelaying till later
Demo / See it in glorious action:
https://jenkins-plugins.g4v.dev/