Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plugin name instead of ID where needed #808

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Sep 15, 2021

In the recent refactoring id became Gatsby internal thing and name is the correct way to get the plugin id/name/slug or how should we call it.

Because of this the release tab is not showing any release details, the CLI install strings are wrong and issues tab is also not working properly.

This PR should fix that.

@zbynek zbynek requested a review from a team as a code owner September 15, 2021 20:17
@halkeye
Copy link
Member

halkeye commented Sep 15, 2021

ouch. I knew this was a bigger change and why i kept putting it off.

Thanks for catching it.

@halkeye
Copy link
Member

halkeye commented Sep 15, 2021

feel free to merge (or auto merge) once ci passes

@timja timja merged commit 41d9381 into jenkins-infra:master Sep 15, 2021
@zbynek zbynek deleted the plugin-name branch September 15, 2021 20:38
@halkeye halkeye added the bug label Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants