Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTS release checklist #122

Merged
merged 16 commits into from Dec 23, 2020
Merged

Conversation

timja
Copy link
Member

@timja timja commented Dec 17, 2020

See issue:
timja#1

Templates:
https://github.com/timja/release/issues/new/choose

Would be good to have a description against each and maybe timings of when it should all happen

Interested in all feedback

.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
- [ ] Publish pre-release Github release

- [ ] Send announcement email

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add here: Check with security team that no security update is planned. If there is, the rest of this checklist does not apply (but hold any updates until the public pre-announcement to the jenkinsci-advisories mailing list).

While every effort is done to inform release team, better safe than sorry. Especially with rotating people.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by the rest of the checklist does not apply?

Doesn't the changelog still need publishing, along with all the other checks done, and someone needs to run the release albeit a different job?


- [ ] Check LTS changelog status

- [ ] Create or update release branch in jenkins-infra/release, e.g. `stable-2.263`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should happen way before then to allow for review.


- [ ] Run job on [release.ci.jenkins.io](https://release.ci.jenkins.io/blue/organizations/jenkins/core%2Fstable%2Frelease/branches/)

- [ ] Publish changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to happen at least 1 day before release if it's a security update to give us time to rebase any security content.

@@ -0,0 +1,71 @@
---
name: "🥇 New LTS release checklist"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 🥇?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random emoji I picked, can remove or replace with a better one

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! Some optional comments for your consideration

.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other suggestions to consider

.github/ISSUE_TEMPLATE/1-lts-release-checklist.md Outdated Show resolved Hide resolved
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@timja
Copy link
Member Author

timja commented Dec 17, 2020

Feel free to just push direct @MarkEWaite might be easier, I’ll try get back to this tomorrow and see how it’s looking

Comment on lines 66 to 67

- [ ] Create or update release branch in jenkins-infra/release, e.g. `stable-2.263`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already covered in an earlier checklist item

Suggested change
- [ ] Create or update release branch in jenkins-infra/release, e.g. `stable-2.263`


- [ ] Confirm the [Red Hat installer acceptance test](https://ci.jenkins.io/job/Infra/job/acceptance-tests/job/install-lts-redhat-rpm/) is passing

- [ ] Adjust state of all [Jira issues](https://issues.jenkins.io/) fixed in the release (see the [changelog](https://www.jenkins.io/changelog-stable) for issue links)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean @MarkEWaite? update the released as field?

blank_issues_enabled: false
contact_links:
- name: "❓ IRC"
url: https://kiwiirc.com/nextclient/irc.freenode.net/?#jenkins-release
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub seems to ignore irc / ircs links 😢

@timja timja merged commit f10b1aa into jenkins-infra:master Dec 23, 2020
@timja timja deleted the lts-release-checklist branch December 23, 2020 09:54
timja added a commit that referenced this pull request Dec 24, 2020
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
(cherry picked from commit f10b1aa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants