Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete paths as workaround for INFRA-905 #11

Merged

Conversation

daniel-beck
Copy link
Contributor

Artifactory appears to have a limit of probably (undocumented) 1024 chars (Office-365-Connector had 1026 chars in its includePattern, the other affected ones were all longer than that).

Keeps the most recently used path/groupId for a given artifact.

To be merged only if JFrog support has no better solution. Or maybe even then. Do we want to prune obsolete paths?

@orrc
Copy link
Member

orrc commented Aug 26, 2016

Removing old paths makes things more secure, rather than less secure, so sounds reasonable to me, if JFrog don't have a solution.

@daniel-beck
Copy link
Contributor Author

Shouldn't really matter all that much from a security POV, and may prevent something like maintenance branch releases using the 'obsolete' pattern.

Extremely unlikely, admittedly, but who knows…

@batmat
Copy link
Contributor

batmat commented Aug 27, 2016

👍 good idea to avoid mistakes. It's so easy to fix if necessary that it's worth doing indeed.

@daniel-beck
Copy link
Contributor Author

JFrog support was unable to offer a workaround.

@daniel-beck daniel-beck merged commit b2a5456 into jenkins-infra:master Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants