Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mihai_virag as developer #1342

Merged
merged 1 commit into from Dec 10, 2019
Merged

Conversation

SilkPerformer
Copy link
Contributor

@SilkPerformer SilkPerformer commented Nov 13, 2019

Description

https://github.com/jenkinsci/silk-performer-plugin

Submitter checklist for changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Merge permission to GitHub repository

  • Check this if newly added person also needs to be given merge permission to the GitHub repo.

@slide
Copy link
Contributor

slide commented Nov 13, 2019

None of the check boxes have been checked, please follow the PR template instructions.

@SilkPerformer
Copy link
Contributor Author

I am new to this and I don't know what should I do next. Can you help me?
Thanks.

@slide
Copy link
Contributor

slide commented Nov 18, 2019

The @ mention is checked, but you didn't @ mention anyone. If you have specific questions about the items in the check list, please send an email to the developers group with the specific questions, it will be easier to answer full there AND it will be a good resource for other people with similar questions to refer to.

@oleg-nenashev
Copy link
Contributor

I assume it could be merged now. Any blockers @slide ?

@slide slide merged commit af933f4 into jenkins-infra:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants