Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding to the maintainers list for this plugin #1473

Merged
merged 1 commit into from Mar 24, 2020

Conversation

markjacksonfishing
Copy link
Contributor

@markjacksonfishing markjacksonfishing commented Mar 24, 2020

Signed-off-by: markyjackson-taulia marky.r.jackson@gmail.com

Description

This is an official request to be made a co-maintainer of the plugin anchore-container-scanner-plugin (https://github.com/jenkinsci/anchore-container-scanner-plugin) as part of my job function.
I have filed the following issue: https://issues.jenkins-ci.org/browse/INFRA-2552
I have made the official request to the dev mailing list

Submitter checklist for changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

Signed-off-by: markyjackson-taulia <marky.r.jackson@gmail.com>
@markjacksonfishing markjacksonfishing requested a review from a team as a code owner March 24, 2020 19:24
@markjacksonfishing
Copy link
Contributor Author

cc: @oleg-nenashev

@markjacksonfishing
Copy link
Contributor Author

@markjacksonfishing
Copy link
Contributor Author

cc: @nurmi for approval

@oleg-nenashev
Copy link
Contributor

Mailing list request is not mandatory for actively maintained plugins FTR. But we need an approval from the current maintainer

@markjacksonfishing
Copy link
Contributor Author

@oleg-nenashev I mainly do that part (mailing list) to serve as an example when new maintainers ask the question of what are the steps they need to take, this becomes my example.

@nurmi
Copy link
Contributor

nurmi commented Mar 24, 2020

@oleg-nenashev @markyjackson-taulia - approved!

Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@slide slide merged commit 48743ee into jenkins-infra:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants