-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timja
as a maintainer to commons-lang3-api plugin
#2659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(non-voting 👍)
(non-voting 👍) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the challenges with https://issues.jenkins.io/browse/JENKINS-69034 and the importance of providing a solution as soon as we can, I recommend that we make an exception for the adoption process and allow that @timja can immediately be added as a plugin maintainer.
I feel like instead of asking the few people on this thread, it should goto dev mailing list for board approval (Since its skipping past the established procedures) |
Request has been posted to the Jenkins developer mailing list. |
The easy fix without plugin governance challenges is to remove the ill-advised dependency from configuration-as-code, reverting jenkinsci/configuration-as-code-plugin#1979. It seems unnecessary to go over maintainers' heads while that's an option. While this is the only plugin with the dependency, there's no benefit in conflict prevention anyway, and the PR provides no justification. |
FTR that has already been done in jenkinsci/configuration-as-code-plugin#2062 so this can wait for maintainer approval or the standard two-week waiting period. |
Proceeding |
Description
@nhojpatrick I'd like to help out with this could you approve please?
see some issues:
jenkinsci/commons-lang3-api-plugin#18
jenkinsci/commons-lang3-api-plugin#12
Submitter checklist for adding or changing permissions
Always
For a newly hosted plugin only
For a new permissions file only
permissions/
directoryartifactId
(pom.xml) is used forname
(permissions YAML file).groupId
/artifactId
(pom.xml) are correctly represented inpath
(permissions YAML file)plugin-${artifactId}.yml
for pluginsWhen adding new uploaders (this includes newly created permissions files)
@
mention an existing maintainer to confirm the permissions request, if applicable@
mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).Reviewer checklist (not for requesters!)
$pluginId Developers
team hasAdmin
permissions while granting the access.@Wadeck
) in this pull request. If an email contact is changed, wait for approval from the security officer.There are IRC Bot commands for it