Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timja as a maintainer to commons-lang3-api plugin #2659

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Conversation

timja
Copy link
Member

@timja timja commented Jul 18, 2022

Description

@nhojpatrick I'd like to help out with this could you approve please?

see some issues:
jenkinsci/commons-lang3-api-plugin#18
jenkinsci/commons-lang3-api-plugin#12

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@timja timja requested a review from a team as a code owner July 18, 2022 16:07
Copy link
Contributor

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non-voting 👍)

@MarkEWaite
Copy link
Contributor

(non-voting 👍)

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the challenges with https://issues.jenkins.io/browse/JENKINS-69034 and the importance of providing a solution as soon as we can, I recommend that we make an exception for the adoption process and allow that @timja can immediately be added as a plugin maintainer.

@halkeye
Copy link
Member

halkeye commented Jul 19, 2022

I recommend that we make an exception for the adoption process

I feel like instead of asking the few people on this thread, it should goto dev mailing list for board approval (Since its skipping past the established procedures)

@MarkEWaite
Copy link
Contributor

I recommend that we make an exception for the adoption process

I feel like instead of asking the few people on this thread, it should goto dev mailing list for board approval (Since its skipping past the established procedures)

Request has been posted to the Jenkins developer mailing list.

@daniel-beck
Copy link
Contributor

The easy fix without plugin governance challenges is to remove the ill-advised dependency from configuration-as-code, reverting jenkinsci/configuration-as-code-plugin#1979. It seems unnecessary to go over maintainers' heads while that's an option. While this is the only plugin with the dependency, there's no benefit in conflict prevention anyway, and the PR provides no justification.

@jglick
Copy link
Contributor

jglick commented Jul 19, 2022

FTR that has already been done in jenkinsci/configuration-as-code-plugin#2062 so this can wait for maintainer approval or the standard two-week waiting period.

@timja timja merged commit 001e5b8 into master Aug 1, 2022
@timja timja deleted the timja-patch-1 branch August 1, 2022 18:57
@timja
Copy link
Member Author

timja commented Aug 1, 2022

Proceeding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants