Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stefan_spieker as developer #2818

Merged
merged 1 commit into from Sep 25, 2022
Merged

Conversation

StefanSpieker
Copy link
Contributor

Description

I would like to adopt the thin-backup-plugin. Which is up for adoption. The maintainer seems to be @tofuatjava since he merged an old PR of mine a few weeks ago.
https://github.com/jenkinsci/thin-backup-plugin

I logged in to Jira sucessfully, but got an error for artifactory:

Login has failed. Due to Incorrect username/password or locked user.

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@StefanSpieker StefanSpieker requested a review from a team as a code owner September 25, 2022 11:26
@timja
Copy link
Member

timja commented Sep 25, 2022

cc @tofuatjava do you approve this?

@tofuatjava
Copy link
Contributor

I always welcome work power and fresh ideas, but as always I want to ensure that the basic idea of Matthias and my - building a efficient backup tool which only backups what needed and not more - will be also be the vision for all new ideas. I started a "remake" on a branch several years ago. To be honest I do not have the time to do it alone...

@timja
Copy link
Member

timja commented Sep 25, 2022

to be clear do you approve this or not?

@StefanSpieker
Copy link
Contributor Author

I do not intend to change the plugin purpose. I think it is a quite useful plugin, which just needs some refreshing.

@tofuatjava
Copy link
Contributor

tofuatjava commented Sep 25, 2022

YES, I approve. Sorry if I was not clear in my last statement.

@timja
Copy link
Member

timja commented Sep 25, 2022

@StefanSpieker it won't work unless you manage to login to Artifactory.

If you are able to login to Jira with the same username and password but not artifactory can you please raise a helpdesk ticket at: https://github.com/jenkins-infra/helpdesk/issues/new/choose

@StefanSpieker
Copy link
Contributor Author

@timja Ok, finally logged into artifactory. Used the wrong password. So now I successfully signed in.

@StefanSpieker StefanSpieker reopened this Sep 25, 2022
@timja timja merged commit 8d9c8e6 into jenkins-infra:master Sep 25, 2022
@StefanSpieker StefanSpieker deleted the patch-1 branch September 26, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants