Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopting the run-condition-plugin #2821

Merged
merged 4 commits into from Sep 26, 2022

Conversation

AayushSaini101
Copy link
Contributor

@AayushSaini101 AayushSaini101 commented Sep 26, 2022

Greetings team, I want to adopt the https://github.com/jenkinsci/run-condition-plugin in order to update the existing feature and add new functionality to the existing plugin.

@MarkEWaite is an existing maintainer and gives his +1 approval

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@AayushSaini101 AayushSaini101 requested a review from a team as a code owner September 26, 2022 10:18
@timja
Copy link
Member

timja commented Sep 26, 2022

please fill out the template

@timja timja added the needs initial login The users need to log in to Jira and/or Artifactory label Sep 26, 2022
@AayushSaini101
Copy link
Contributor Author

@timja Sir, I have already login to the Artifactory and jira

@timja timja removed the needs initial login The users need to log in to Jira and/or Artifactory label Sep 26, 2022
@timja timja merged commit db5f2b7 into jenkins-infra:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants