Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cd for unique-id plugin #3179

Merged
merged 1 commit into from Mar 8, 2023
Merged

Conversation

jtnord
Copy link
Contributor

@jtnord jtnord commented Mar 8, 2023

Description

enable CD for https://github.com/jenkinsci/unique-id-plugin

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

When enabling automated releases (cd: true)

  • Add a link to the pull request, which enables continuous delivery for your plugin or component.
    Follow the documentation to ensure, your pull request is set up properly.

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@jtnord jtnord requested a review from a team as a code owner March 8, 2023 13:38
@jtnord
Copy link
Contributor Author

jtnord commented Mar 8, 2023

it appears as though I do not have admin access to the repo - could you check that unique-id Developers has admin rights please.

@NotMyFault NotMyFault merged commit 231df6e into jenkins-infra:master Mar 8, 2023
@NotMyFault
Copy link
Member

it appears as though I do not have admin access to the repo - could you check that unique-id Developers has admin rights please.

I added you to the repo team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants