-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace manifest's icon from one from jenkins.io #20
Conversation
0d75d75
to
e286a21
Compare
e286a21
to
39a8213
Compare
This PR exchanges the gatsby icon with the Jenkins one, to prevent putting the gatsby logo in place, which currently is distributed as https://stories.jenkins.io/favicon-32x32.png?v=53aa06cf17e4239d0dba6ffd09854e02 |
This is so weird. I clearly (as screenshotted) see the jenkins icon, but https://realfavicongenerator.net/favicon_checker?protocol=https&site=stories.jenkins.io does show the gatsby icon for the app icon manifest. |
Looks like we have two manifest, one from the site layout plugin, one from the manifest plugin |
So I think the proper fix is to 1) remove that gatsby plugin 2) update gatsby-plugin-jenkins-layout to take in name and shortname. I can handle #2 as soon as i finish breakfast and my electronics work. |
51dae1f
to
9ada6c3
Compare
Done 1), I also removed the obsolete gatsby png. |
No description provided.