Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manifest's icon from one from jenkins.io #20

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

NotMyFault
Copy link
Member

No description provided.

@halkeye
Copy link
Member

halkeye commented Apr 16, 2023

I'm not sure what this is fixing. The manifest has an icon, and i think the favicon from jenkins.io is small, and manifest wants like 512

image

@NotMyFault
Copy link
Member Author

I'm not sure what this is fixing.

This PR exchanges the gatsby icon with the Jenkins one, to prevent putting the gatsby logo in place, which currently is distributed as https://stories.jenkins.io/favicon-32x32.png?v=53aa06cf17e4239d0dba6ffd09854e02

@halkeye halkeye changed the title Grab favicon from jenkins.io Replace manifest's icon from one from jenkins.io Apr 16, 2023
@halkeye
Copy link
Member

halkeye commented Apr 16, 2023

This is so weird. I clearly (as screenshotted) see the jenkins icon, but https://realfavicongenerator.net/favicon_checker?protocol=https&site=stories.jenkins.io does show the gatsby icon for the app icon manifest.

@halkeye
Copy link
Member

halkeye commented Apr 16, 2023

curl -qs 'https://stories.jenkins.io/' | tr '<' '\n' | grep manifest
link data-react-helmet="true" href="/site.webmanifest" rel="manifest"/>
link rel="manifest" href="/manifest.webmanifest" crossorigin="anonymous"/>

Looks like we have two manifest, one from the site layout plugin, one from the manifest plugin

@halkeye
Copy link
Member

halkeye commented Apr 16, 2023

So I think the proper fix is to 1) remove that gatsby plugin 2) update gatsby-plugin-jenkins-layout to take in name and shortname.

I can handle #2 as soon as i finish breakfast and my electronics work.

@NotMyFault
Copy link
Member Author

So I think the proper fix is to 1) remove that gatsby plugin

Done 1), I also removed the obsolete gatsby png.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants