-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lot of wiki overrides for plugins with incorrect/missing URLs. #14
Conversation
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Fixed a typo ( |
I have some doubts whether maintaining a central list of plugin/URL mappings is the correct approach going forward. |
I agree. But it will be a while before all plugins have their POM updated and a new release made, so this is just an easy and instant fix for the ~50 plugins here that currently have no information at all in the plugin list aside from the artifact ID, e.g. "additional-identities-plugin", or display the plugin name but no wiki link or description. Like it says at the very top of the file, ideally all entries in this file should be temporary. |
Adding wiki link where it is missing does not have to be reviewed by the maintainer, imho. |
As we discussed in the meeting yesterday, it's useless without a new release that includes the changed metadata, and maintainers may object to others directly committing to their plugin, so a PR would be best. |
@orrc Do you think this should still be merged after the previous governance meeting? |
f028ac5
to
2d9488c
Compare
@daniel-beck Yes, this lets us grandfather in the existing releases with missing/bad URLs. I've fixed some UC bugs, and got in touch with some developers and updated this commit with more URLs. If you could merge this now, that would be great. |
Some plugins do have the correct URL in the POM, but haven't been released yet, a few are simple URL typos, and the majority specify no wiki URL in the POM.
The current UC code will throw an exception and give up if this override is included; we need to wait for pull request jenkins-infra#20 to be merged.
Add a lot of wiki overrides for plugins with incorrect/missing URLs.
I changed the update centre code to be more strict about wiki URLs, and examined every single error that resulted...
Some plugins do have the correct URL in the POM, but haven't been released yet, a few are simple URL typos, but the majority specify no wiki URL in the POM.
Ideally somebody would also now make pull requests for most of the plugins on the list...