Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more plugin renames/deprecations. #19

Merged
merged 1 commit into from
May 18, 2015

Conversation

orrc
Copy link
Member

@orrc orrc commented May 18, 2015

No description provided.

@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

hipchat-plugin # renamed to hipchat
hudson-logaction-plugin # renamed to logaction-plugin
icon-shim-plugin # renamed to icon-shim
mogotest # deprecated: mogotest service no longer exists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh ok, that's because the UC generator only creates directories for plugins that are listed in the UC JSON.

The mogotest plugin does exist in Artifactory, and was used by a number of people:
http://stats.jenkins-ci.org/plugin-installation-trend/mogotest.stats.json

Because the Mogotest wiki page is marked as deprecated, it's no longer in the UC.

But the UC only recognises the plugin as deprecated at the moment because it guesses what the mogotest wiki page URL is:

mogotest
** No wiki page specified.. picking one with similar name.
Using 'mogotest' for mogotest

Which is behaviour I've stopped in #20 — plugins now need to explicitly provide a wiki URL.
So I guess when that's merged, mogotest would be excluded anyway due to not having a valid wiki URL, but since it's never coming back, I thought I may as well add it to the blacklist (and off the list of bad plugins without URLs).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

daniel-beck added a commit that referenced this pull request May 18, 2015
Add more plugin renames/deprecations.
@daniel-beck daniel-beck merged commit beb31db into jenkins-infra:master May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants