Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude plugins without a valid wiki page from the Update Centre JSON files #20

Merged
merged 2 commits into from
Jun 1, 2015
Merged

Exclude plugins without a valid wiki page from the Update Centre JSON files #20

merged 2 commits into from
Jun 1, 2015

Commits on Jun 1, 2015

  1. Exclude plugins without a valid wiki page from the Update Centre JSON… 

    … files.

The criteria for inclusion are:
- Plugins must specify a Jenkins wiki URL in their pom.xml, via the <url> tag
- The wiki page must exist on the Jenkins wiki
- The wiki page must be a child of the "Plugins" page

Also accepted are:
- Wiki short URLs (e.g. /x/GYCGAQ)
- Wiki URLs with a numeric ID (e.g. /pages/viewpage.action?pageId=60915753)
- URLs which have legacy URL prefixes (e.g. non-HTTPS, wiki.hudson-ci.org)
- URLs ending with a trailing slash

Plugins not meeting these criteria will not be included in the Update Centre
JSON file, nor in the release history JSON file.

As before, plugins may also be excluded via the "artifact-ignores.properties"
file, or if a plugin does specify a valid wiki page, but that wiki page has the
"plugin-deprecated" label.

While building the plugin list, more informational output is now printed to the
console regarding why plugins are being excluded, or whether their wiki URL was
rewritten to the canonical wiki URL format.

A summary of the total number of included, excluded and deprecated plugins is
also shown at the end of building the Update Centre plugin list.

A number of test cases were added to test the basic URL resolution process, as
well as some of the rarer types of URL found in currently-released plugins.
    @orrc
    orrc committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    66ae4f8 View commit details
    Browse the repository at this point in the history

  2. When building the old/stable UC files, keep plugins without wiki page… 

    …s for now.

Even if plugin developers update their plugins to include a wiki URL, and make a
new release, this will not apply to older plugin releases.  Because the UC for
LTS releases may only include older plugin releases, and not the latest version
of any given plugin, we should not exclude those plugins because they don't have
a wiki page.

This is a workaround which should ideally be removed once we no longer generate
UC files for LTS 1.596, which was the last LTS in which we tolerated plugins
without a valid wiki URL.
    @orrc
    orrc committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    38a695b View commit details
    Browse the repository at this point in the history