Overhaul update site generation #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2020
oleg-nenashev
approved these changes
May 9, 2020
| @@ -239,8 +248,8 @@ | |||
| </repositories> | |||
|
|
|||
| <scm> | |||
| <connection>scm:git:git://github.com/jenkinsci/backend-update-center2.git</connection> | |||
| <developerConnection>scm:git:ssh://git@github.com/jenkinsci/backend-update-center2.git</developerConnection> | |||
| <connection>scm:git:git://github.com/jenkins-infra/update-center2.git</connection> | |||
There was a problem hiding this comment.
Should it be 'update-center3' now? :)
zbynek
reviewed
May 9, 2020
daniel-beck
force-pushed
the
mavenless-plus
branch
from
4b416e0
to
6e3e332
Compare
FTR no need to panic:
|
It looks like my testing of fastjson output compatibility was incomplete and the library generates float numbers different from what Jenkins core writes out as the 'canonical' form (json-lib), resulting in checksum errors. Very small numbers are written in scientific notation in both json-lib and fastjson, but fastjson uses 'E' while json-lib uses 'e'. Floats without fractional part are written like ints by json-lib, while fastjson writes them with '.0' suffix. This basically means that, without switching out the serialization library, we're unable to have floats in update center data.
Especially now that the wiki is pretty much gone
|
Oleg mentioned a preference for this to be squashed, so that's how I merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large-scale modernization of this tool.
Notable output changes:
aliyun-container-service-deployhas all of its releases suspended now, so it's gone from update sites.correct_*checksums and signatures, not the pre-1.433 variant. This means update center output is no longer compatible with Jenkins 1.433 (late 2011)latest/directory, orplugin-documentation-urls.json.latest/directory,plugin-documentation-urls.json, orlatestCore.txt.While we remove some redundancy, I checked what files are required for things to continue working, and they are still being created:
update-center.*files andlatestCore.txtlatestCore.txtstill existsstablesitelatestCore.txtstill existsupdate-center.*still exist (also needed for actual Jenkins)release-history.jsonstill existscurrentupdate siteplugin-documentation-urls.jsonstill existscurrentupdate siteplugin-versions.jsonstill existsOther changes:
It's running experimentally at https://trusted.ci.jenkins.io:1443/job/update-center2 from the origin branch with the same name, and completes a full run (except publishing/rsync) in ~45 seconds.