small fixes for helmfile handling #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doh, it's the release name and not the chart name that is unique per namespace
|
Kudos, SonarCloud Quality Gate passed!
|
tomhobson
approved these changes
Mar 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomhobson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Failed to merge this PR due to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix to report solves the problem that lastDeployTime is updated on every execution of
jx gitops helmfile reportif you have several releases in the same namespace of the same chart, but different versions. The bug mainly causes problems with merge conflicts.The change to status means that we avoid creating deployment in github for releases without lastDeployed. Since this also means that version is missing, which is caught later with a warning message, it essentially means that a warning log message is avoided.