Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with duplicate helmfiles being returned #939

Merged
merged 3 commits into from
Sep 15, 2023
Merged

fix: issue with duplicate helmfiles being returned #939

merged 3 commits into from
Sep 15, 2023

Conversation

Skisocks
Copy link
Contributor

Noticed issues with jx gitops helmfile report where namespaces were being reported twice. Seems that GatherHelmfiles() is both recursively finding a nested helmfile and appending it, but then also appending the same file by calculating it's location.

Removing the calculation resolves the issue but highlighted another issue in jx gitops helmfile resolve where if both a "jx3" and "jenkins-x" repository were found then only one was removed. This has also been fixed.

@jenkins-x-bot
Copy link
Contributor

Hi @Skisocks. Thanks for your PR.

I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@Skisocks
Copy link
Contributor Author

/cc @tomhobson @msvticket

@msvticket
Copy link
Contributor

/ok-to-test

msvticket
msvticket requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@msvticket msvticket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you are tackling this issue! It's been on my radar since sometime this spring...

I'd say the removal of unused repositories could be improved a bit further as I don't see why only jx3 and jenkins-x should be cleaned away. I suggest you first loop through the releases and create a map with the used repositores and then when iterating though the repositories skip those that are not used.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Skisocks
Copy link
Contributor Author

/cc @msvticket

@msvticket
Copy link
Contributor

/approve

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

11 similar comments
@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

13 similar comments
@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 504743a into jenkins-x-plugins:main Sep 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msvticket msvticket msvticket approved these changes

@tomhobson tomhobson Awaiting requested review from tomhobson

Assignees
No one assigned
Labels
approved ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skisocks @jenkins-x-bot @msvticket