refactor: upgrade go version to 1.18.6 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc ankitm123 |
ankitm123
approved these changes
Sep 29, 2022
|
Modify the owners file (check jx-pipeline for reference) and keep vbehar in the owners list. |
thanks ;-) |
vbehar
approved these changes
Sep 30, 2022
rajatgupta24
force-pushed
the
update-go-1.18
branch
from
d415fc3
to
df57919
Compare
rajatgupta24
commented
Sep 30, 2022
rajatgupta24
requested review from
ankitm123 and
vbehar
and removed request for
ankitm123 and
vbehar
|
/hold |
rajatgupta24
force-pushed
the
update-go-1.18
branch
from
df57919
to
ec06529
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ankitm123
approved these changes
Sep 30, 2022
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitm123, vbehar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the go to
1.18.6.And the
linter.shneed to be updated.related to: jenkins-x/jx#8283
go.modfile.go mod tidyand ensure that it does not error out.GO_VERSIONinmakefileto the version you are upgrading.make build.make test.make lint.