-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade go version to 1.18.6 #175
refactor: upgrade go version to 1.18.6 #175
Conversation
Hi @aahmed7. Thanks for your PR. I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
/assign @ankitm123 |
ran a basic runtime test as well apart from
|
Makefile
Outdated
@@ -13,7 +13,7 @@ ORG := jenkins-x | |||
ORG_REPO := $(ORG)/$(NAME) | |||
RELEASE_ORG_REPO := $(ORG_REPO) | |||
ROOT_PACKAGE := github.com/$(ORG_REPO) | |||
GO_VERSION := 1.17.9 | |||
GO_VERSION := 1.18.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace GO_VERSION with this section: https://github.com/jenkins-x-plugins/jx-pipeline/blob/89593c6e1e9d2c01b8a26296f53b6fdedcc48410/Makefile#L16-L22.
Remember to upgrade the k8s client libraries to 0.22.X here: Lines 87 to 91 in 932a56f
|
@ankitm123 sure |
Kudos, SonarCloud Quality Gate passed! |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitm123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aahmed7 thanks for doing this. We will be participating in hacktoberfest, and we will most likely have lot of issues for people to contribute to :) |
This upgrades go version to 1.18
related to: jenkins-x/jx#8283
make build
make test