Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade go version to 1.18.6 #175

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

aahmed7
Copy link
Contributor

@aahmed7 aahmed7 commented Sep 29, 2022

This upgrades go version to 1.18

related to: jenkins-x/jx#8283

  • Change the version in go.mod file.
  • Run go mod tidy and ensure that it does not error out.
  • Change GO_VERSION in the makefile to the version you are upgrading.
  • Check if there are any references to an older version and replace those.
  • Verify that
    • The build works by running make build
    • Tests are working, by running make test

@jenkins-x-bot
Copy link
Contributor

Hi @aahmed7. Thanks for your PR.

I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@aahmed7
Copy link
Contributor Author

aahmed7 commented Sep 29, 2022

/assign @ankitm123

@aahmed7
Copy link
Contributor Author

aahmed7 commented Sep 29, 2022

ran a basic runtime test as well apart from make test

$ ./build/jx-verify version
version: -dev+932a56f

Makefile Outdated
@@ -13,7 +13,7 @@ ORG := jenkins-x
ORG_REPO := $(ORG)/$(NAME)
RELEASE_ORG_REPO := $(ORG_REPO)
ROOT_PACKAGE := github.com/$(ORG_REPO)
GO_VERSION := 1.17.9
GO_VERSION := 1.18.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitm123
Copy link
Contributor

ankitm123 commented Sep 29, 2022

Remember to upgrade the k8s client libraries to 0.22.X here:

jx-verify/go.mod

Lines 87 to 91 in 932a56f

replace (
k8s.io/api => k8s.io/api v0.21.4
k8s.io/apimachinery => k8s.io/apimachinery v0.21.4
k8s.io/client-go => k8s.io/client-go v0.21.4
)

@aahmed7
Copy link
Contributor Author

aahmed7 commented Sep 29, 2022

@ankitm123 sure

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ankitm123
Copy link
Contributor

/ok-to-test

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit e43267f into jenkins-x-plugins:main Sep 29, 2022
@ankitm123
Copy link
Contributor

@aahmed7 thanks for doing this. We will be participating in hacktoberfest, and we will most likely have lot of issues for people to contribute to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants