Skip to content
This repository has been archived by the owner on Apr 8, 2021. It is now read-only.

feat: updated skaffold to v0.34.0 #43

Closed
wants to merge 1 commit into from

Conversation

nelsonsilva
Copy link
Contributor

Updated skaffold to v0.34.0.
Main purpose is to have GoogleContainerTools/skaffold@355fae5 to fix Kaniko builds with insecure registry which is available since v0.32.0

@jenkins-x-bot
Copy link
Contributor

Hi @nelsonsilva. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@garethjevans
Copy link
Member

/ok-to-test

@garethjevans
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

@nelsonsilva: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tekton 3ac5c33 link /test this

View all Builds for this Pull Request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants