chore: Lighthouse Goes GA blog post #2836
Conversation
|
⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2836 here |
There was a problem hiding this comment.
Nice blog. I am a bit "confused" over the use of github.com. Not sure what the proper thing to use is here, just "GitHub" or "GitHub Free" or maybe one needs to further elaborate what we mean.
On a side note, I would heavily advocate moving to a one sentence per line approach. Maybe not so important for a blog which is probably not changing so much, but imo it is a good style for markdown.
|
Some more background around sentence per line - https://asciidoctor.org/docs/asciidoc-recommended-practices/#one-sentence-per-line. I have been writing and re-writing the docs for several projects by now and adopting one sentence per line was always welcomed (after some initial resistance ;-)) |
|
|
||
| In May of this year, Jenkins X switched from using [Prow](https://github.com/kubernetes/test-infra/tree/master/prow) as its default webhook handler to using [Lighthouse](https://github.com/jenkins-x/lighthouse). This is the result of almost a year of work, and provides some significant improvements for users of Jenkins X. You can find more information on the differences between Prow and Lighthouse [here](https://jenkins-x.io/docs/reference/components/lighthouse/#comparisons-to-prow). | ||
|
|
||
| Most notably, Jenkins X now properly supports GitHub Enterprise as well as github.com, with preview support for GitLab and BitBucket Server. Prow only supports github.com, so until now, Jenkins X users have had to jump through hoops or accept significant limitations to their workflows in order to use any other SCM providers. Lighthouse is tested against every provider we list support for, including the preview support for GitLab and BitBucket Server. While some functionality may not behave exactly the same on all providers, the core functionality of [ChatOps](https://jenkins-x.io/docs/build-test-preview/chatops/) should work on all. |
There was a problem hiding this comment.
Could you specify what version of GitLab has "preview support"? From what I can tell from their website, there's:
- gitlab.com (SaaS; version of GitLab depends on your pricing plan)
- GitLab Community Edition (self-managed/on-premise; open-source and for free)
- GitLab Enterprise Edition (self-managed/on-premise; proprietary and commercial only)
Maybe we can do the same for GitHub and Bitbucket and add a table that clearly lists what's in GA vs. preview vs. not supported at all?
There was a problem hiding this comment.
It should be any of them, but yeah, will do.
|
|
||
| In May of this year, Jenkins X switched from using [Prow](https://github.com/kubernetes/test-infra/tree/master/prow) as its default webhook handler to using [Lighthouse](https://github.com/jenkins-x/lighthouse). This is the result of almost a year of work, and provides some significant improvements for users of Jenkins X. You can find more information on the differences between Prow and Lighthouse [here](https://jenkins-x.io/docs/reference/components/lighthouse/#comparisons-to-prow). | ||
|
|
||
| Most notably, Jenkins X now properly supports GitHub Enterprise as well as github.com, with preview support for GitLab and BitBucket Server. Prow only supports github.com, so until now, Jenkins X users have had to jump through hoops or accept significant limitations to their workflows in order to use any other SCM providers. Lighthouse is tested against every provider we list support for, including the preview support for GitLab and BitBucket Server. While some functionality may not behave exactly the same on all providers, the core functionality of [ChatOps](https://jenkins-x.io/docs/build-test-preview/chatops/) should work on all. |
There was a problem hiding this comment.
I would write out "SCM" once. I assume it stands for "Source Code Management"? I wouldn't be surprised if there are quite a few people who don't know that. Maybe we also explain it in the docs since it's now scm.PullRequest, etc. if I understood it correctly?
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
|
⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2836 here |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hferentschik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2836 here |
I'd appreciate any feedback. =)