Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove highlightjs and use chroma #2957

Merged
merged 1 commit into from Jul 14, 2020
Merged

fix: remove highlightjs and use chroma #2957

merged 1 commit into from Jul 14, 2020

Conversation

ankitm123
Copy link
Member

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

fixes #2943

ankitm123
ankitm123 commented Jul 13, 2020
View reviewed changes
assets/scss/_code.scss Outdated Show resolved Hide resolved
ankitm123
ankitm123 commented Jul 13, 2020
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

ankitm123
ankitm123 commented Jul 13, 2020
View reviewed changes
assets/scss/_code.scss
@@ -45,7 +45,6 @@


> code {
padding: 15px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was giving the extra indentation to the first line in a code snippet.

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

@MarckK
Copy link
Member

MarckK commented Jul 13, 2020

Thank you, @ankitm123! Looks good =) There is a bit of extra dark highlighting going on that would be great to remove, eg:
Screenshot 2020-07-13 at 12 09 26

@ankitm123
Copy link
Member Author

ankitm123 commented Jul 13, 2020 •
edited

Thank you, @ankitm123! Looks good =) There is a bit of extra dark highlighting going on that would be great to remove, eg:

This seems like a chroma/hugo issue. Let me check if there's a fix.
Actually this is fixed. The PR updates the version of hugo to 0.74.0, which uses chroma 0.7.3 which has the fix for terraform formatting. However, the pr checks and build use an older version of hugo (0.65.3). Locally I see the output rendered properly :)

@MarckK
Copy link
Member

MarckK commented Jul 13, 2020

Awesome! Thank you, @ankitm123

@MarckK
Copy link
Member

MarckK commented Jul 13, 2020

/lgtm

@ankitm123
Copy link
Member Author

/hold

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

@ankitm123
Copy link
Member Author

/hold cancel

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

1 similar comment
@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

@ankitm123
Copy link
Member Author

ankitm123 commented Jul 13, 2020 •
edited

/hold

Getting compilation issues with the latest hugo version, checking ...

Seems like the issue is related to a kernel bug in the latest version of ubuntu which is detected in go 1.14, and try to work around it, and throw error: golang/go#37436 (comment)

A possible fix would be to downgrade the version of go to 1.13 in the hugo docker image.
Trying GODEBUG=asyncpreemptoff=1 did not work in the docker-compose file

@ankitm123 ankitm123 mentioned this pull request Jul 13, 2020
Closed
@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

@ankitm123
Copy link
Member Author

/hold cancel

@ankitm123
Copy link
Member Author

/lgtm

@jenkins-x-bot
Copy link
Contributor

@ankitm123: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@ankitm123
fix: remove highlightjs and use chroma
bdcee82 
Signed-off-by: ankitm123 <ankitmohapatra123@gmail.com>
@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview environment jenkins-x-jx-docs-pr-2957 here

@MarckK
Copy link
Member

MarckK commented Jul 14, 2020

Looks fantastic! Thank you, @ankitm123 :)

/lgtm

@jenkins-x-bot jenkins-x-bot merged commit e64a89a into jenkins-x:master Jul 14, 2020
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123, MarckK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MarckK MarckK

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix syntax highlighting for terraform code blocks
3 participants
@ankitm123 @jenkins-x-bot @MarckK