Skip to content

Commit

Permalink
vault(vault): Disable storing secrets in vault for --gitops for now
Browse files Browse the repository at this point in the history
This should be reenabled once we can consume the secrets properly.
  • Loading branch information
agentgonzo committed Nov 28, 2018
1 parent 7aae7af commit 07db653
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion pkg/jx/cmd/create_cluster_gke.go
Expand Up @@ -306,7 +306,9 @@ func (o *CreateClusterGKEOptions) createClusterGKE() error {
return err
}

if o.CreateClusterOptions.InstallOptions.GitOpsMode || o.CreateClusterOptions.InstallOptions.Vault {
// TODO - Reenable vault for GitOpsMode
//o.CreateClusterOptions.InstallOptions.GitOpsMode || o.CreateClusterOptions.InstallOptions.Vault {
if o.CreateClusterOptions.InstallOptions.Vault {
if err = InstallVaultOperator(&o.CommonOptions, ""); err != nil {
return err
}
Expand Down
4 changes: 3 additions & 1 deletion pkg/jx/cmd/install.go
Expand Up @@ -681,7 +681,9 @@ func (options *InstallOptions) Run() error {
options.Flags.Domain = initOpts.Flags.Domain
}

if options.Flags.GitOpsMode && !options.Flags.NoGitOpsVault || options.Flags.Vault {
// TODO - we want to enable storing secrets in Vault for gitops. Reenable this once the feature is finished
//if options.Flags.GitOpsMode && !options.Flags.NoGitOpsVault || options.Flags.Vault {
if options.Flags.Vault {
// Install Vault Operator into the new env
err = InstallVaultOperator(&options.CommonOptions, "")
if err != nil {
Expand Down

0 comments on commit 07db653

Please sign in to comment.