docker-credential-ecr-login in builder base

[ysaakpr]

In order to do ecr integration, can we make the builder base to support docker-credential-ecr-login binary.

[jstrachan]

see #399 (comment)

we already have a secret mounted into all build pods that contains the docker config.json required to talk to any docker registry

[ysaakpr]

I already tried with this approach, but i am always getting Error: docker-credential-ecr-login not found in $PATH. Following is my config.json.

{
  "credHelpers": {
    "account.dkr.ecr.ap-south-1.amazonaws.com": "ecr-login"
  }
}

Am i doing anything wrong. I was referring https://aws.amazon.com/blogs/compute/authenticating-amazon-ecr-repositories-for-docker-cli-with-credential-helper/ and by which there should be a binary named docker-credential-ecr-login in the PATH which is not there in any builder-base or agents

[jstrachan]

looks like we'll need to mount a Secret for the docker-credential-ecr-login

[ysaakpr]

docker-credential-ecr-login is not a secret, btw its a binary file, having that the docker will automatically able to authenticate with ecr, without configuring the ecr secrets. Can you direct me if i am wrong ?

[ysaakpr]

@jstrachan @rajdavies created a pull request to support ecr-login helper in the builder base. Can you please try merging it if you find its good to go..
jenkins-x/builder-base#358

[jstrachan]

@yahavi many thanks, will take a look!

[jstrachan]

@yahavi merged - will have a release with it inside in a few hours, I'll update this issue when its out

[ysaakpr]

@jstrachan Thanks a lot...Looks like jx-platform and jenkins-x-image are not building. You might need to trigger a manual build for both of them.

[jstrachan]

@yahavi its released now! If you do

jx upgrade cli
jx upgrade platform
jx version

you should get 0.0.1547 for the platform version which has this fix