chore(tekton): Add Tekton BDD test context to PRs #4301

abayer · 2019-06-17T15:12:54Z

This is waiting for @daveconde to nail down cluster cleanup before it's ready to merge.

/hold

abayer · 2019-06-17T15:13:03Z

/test tekton

codecov · 2019-06-17T15:49:51Z

Codecov Report

❗ No coverage uploaded for pull request base (master@ae0c16c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4301   +/-   ##
=========================================
  Coverage          ?   41.64%           
=========================================
  Files             ?      802           
  Lines             ?   100572           
  Branches          ?        0           
=========================================
  Hits              ?    41879           
  Misses            ?    55417           
  Partials          ?     3276

Flag	Coverage Δ
#integration	`41.64% <ø> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae0c16c...db2ff7b. Read the comment docs.

codecov · 2019-06-17T15:49:56Z

Codecov Report

Merging #4301 into master will decrease coverage by 0.02%.
The diff coverage is 24.57%.

@@            Coverage Diff             @@
##           master    #4301      +/-   ##
==========================================
- Coverage   43.58%   43.55%   -0.03%     
==========================================
  Files         834      838       +4     
  Lines      105952   106187     +235     
==========================================
+ Hits        46176    46254      +78     
- Misses      55730    55890     +160     
+ Partials     4046     4043       -3

Flag	Coverage Δ
#e2e	`30.33% <24.57%> (ø)`	⬆️
#integration	`41.93% <24.57%> (-0.05%)`	⬇️

Impacted Files	Coverage Δ
pkg/cmd/step_bdd.go	`45.85% <0%> (-2.14%)`	⬇️
pkg/cmd/step.go	`86.95% <100%> (+0.28%)`	⬆️
pkg/cmd/deletecmd/delete.go	`80.48% <100%> (+0.48%)`	⬆️
pkg/cmd/step/e2e/step_e2e_gc.go	`18.75% <18.75%> (ø)`
pkg/cmd/step/e2e/step_e2e_label.go	`20.77% <20.77%> (ø)`
pkg/cmd/deletecmd/delete_gke.go	`40% <40%> (ø)`
pkg/cmd/step/e2e/step_e2e.go	`57.89% <57.89%> (ø)`
pkg/auth/auth_config.go	`44.56% <0%> (-0.73%)`	⬇️
pkg/cmd/testhelpers/cmd_test_helpers.go	`66.09% <0%> (-0.29%)`	⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11278b3...6ab5953. Read the comment docs.

abayer · 2019-06-17T15:49:56Z

/test tekton

abayer · 2019-06-17T15:57:45Z

/test tekton

abayer · 2019-06-17T16:11:42Z

/test tekton

abayer · 2019-06-17T16:25:46Z

/test tekton

abayer · 2019-06-17T16:35:09Z

/test tekton

abayer · 2019-06-17T16:44:37Z

/test tekton

abayer · 2019-06-17T16:47:09Z

/test tekton

abayer · 2019-06-17T16:56:48Z

/test tekton

abayer · 2019-06-17T17:38:01Z

/test tekton

abayer · 2019-06-17T17:51:01Z

/test tekton

daveconde · 2019-06-17T20:01:32Z

/test tekton

abayer · 2019-06-17T20:55:45Z

/test tekton

abayer · 2019-06-17T21:33:51Z

/test tekton

abayer · 2019-07-02T18:08:31Z

/test tekton

abayer · 2019-07-02T18:42:35Z

/test tekton

abayer · 2019-07-02T18:50:32Z

/hold

Putting on hold until #4544 lands so that we can rebase on top of it and not have the actual bug fixes in here too.

abayer · 2019-07-02T18:58:42Z

/test tekton

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

- jx step e2e gc - jx step e2e label mycluster --delete - jx step e2e label mycluster --keep fixes: jenkins-x#3914 Signed-off-by: David Conde <dconde@cloudbees.com>

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

abayer · 2019-07-02T19:35:19Z

/test images

Waiting on jenkins-x/jx#4301 to merge before this should get merged. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

abayer · 2019-07-02T20:00:05Z

/test tekton

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

daveconde · 2019-07-02T20:56:30Z

/lgtm

jenkins-x-bot · 2019-07-02T20:56:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daveconde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [daveconde]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abayer · 2019-07-02T21:22:37Z

/hold cancel

jenkins-x-bot added the do-not-merge/hold label Jun 17, 2019

jenkins-x-bot added the size/XS label Jun 17, 2019

jenkins-x-bot added size/M and removed size/XS labels Jun 17, 2019

jenkins-x-bot added size/L and removed size/M labels Jun 17, 2019

abayer force-pushed the test-tekton-context branch from ef9965a to b4ca0d2 Compare June 17, 2019 17:17

jenkins-x-bot added size/M and removed size/L labels Jun 17, 2019

abayer force-pushed the test-tekton-context branch from b4ca0d2 to 63f0fa6 Compare June 17, 2019 17:50

abayer force-pushed the test-tekton-context branch from 63f0fa6 to a080bd1 Compare June 17, 2019 20:55

abayer force-pushed the test-tekton-context branch from a080bd1 to 8db25ce Compare June 17, 2019 21:07

jenkins-x-bot added size/L and removed size/M labels Jun 17, 2019

abayer force-pushed the test-tekton-context branch from d8fd8bb to d5c0593 Compare July 2, 2019 18:08

abayer force-pushed the test-tekton-context branch from 2d109ad to 231515b Compare July 2, 2019 18:40

abayer changed the title ~~Add Tekton BDD test context to PRs~~ chore(tekton): Add Tekton BDD test context to PRs Jul 2, 2019

abayer mentioned this pull request Jul 2, 2019

fix(tekton): Don't error on empty build list initially in get build logs, dedupe PipelineResource names #4544

Merged

2 tasks

jenkins-x-bot added do-not-merge/hold size/XL and removed size/L labels Jul 2, 2019

abayer and others added 3 commits July 2, 2019 15:34

chore: Updating tekton BDD tests to run and be covered

2f858e5

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

feat: Add new jx steps to clean up e2e tests

70c6977

- jx step e2e gc - jx step e2e label mycluster --delete - jx step e2e label mycluster --keep fixes: jenkins-x#3914 Signed-off-by: David Conde <dconde@cloudbees.com>

fix: add --async to GKE cluster delete call

d803a68

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

abayer force-pushed the test-tekton-context branch from 8d028e5 to d803a68 Compare July 2, 2019 19:34

abayer added a commit to abayer/prow-config-tekton that referenced this pull request Jul 2, 2019

chore: Turn on Tekton BDD for jx PRs

6e90ecb

Waiting on jenkins-x/jx#4301 to merge before this should get merged. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

abayer mentioned this pull request Jul 2, 2019

chore: Turn on Tekton BDD for jx PRs jenkins-x/prow-config-tekton#106

Merged

fix: Pick up region/zone from created cluster info

52b9afd

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

abayer force-pushed the test-tekton-context branch from 6ab5953 to 52b9afd Compare July 2, 2019 20:55

jenkins-x-bot added the lgtm label Jul 2, 2019

jenkins-x-bot added the approved label Jul 2, 2019

daveconde mentioned this pull request Jul 2, 2019

WIP - 3914 bdd cleanup #4515

Closed

jenkins-x-bot removed the do-not-merge/hold label Jul 2, 2019

jenkins-x-bot merged commit 0f7b06a into jenkins-x:master Jul 2, 2019

abayer mentioned this pull request Jul 2, 2019

chore: Add Tekton BDD to release coverage baseline generation #4547

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(tekton): Add Tekton BDD test context to PRs #4301

chore(tekton): Add Tekton BDD test context to PRs #4301

abayer commented Jun 17, 2019 •

edited

abayer commented Jun 17, 2019

codecov bot commented Jun 17, 2019

codecov bot commented Jun 17, 2019 •

edited

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

daveconde commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

daveconde commented Jul 2, 2019

jenkins-x-bot commented Jul 2, 2019

abayer commented Jul 2, 2019

chore(tekton): Add Tekton BDD test context to PRs #4301

chore(tekton): Add Tekton BDD test context to PRs #4301

Conversation

abayer commented Jun 17, 2019 • edited

abayer commented Jun 17, 2019

codecov bot commented Jun 17, 2019

Codecov Report

codecov bot commented Jun 17, 2019 • edited

Codecov Report

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

daveconde commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jun 17, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

abayer commented Jul 2, 2019

daveconde commented Jul 2, 2019

jenkins-x-bot commented Jul 2, 2019

abayer commented Jul 2, 2019

abayer commented Jun 17, 2019 •

edited

codecov bot commented Jun 17, 2019 •

edited