Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Tekton BDD to release coverage baseline generation #4547

Merged

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Jul 2, 2019

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Followup to #4301. Also fixes a bad image name I put in. Sigh.

Special notes for the reviewer(s)

/assign @pmuir
/assign @daveconde
/assign @cagiti

Which issue this PR fixes

n/a

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0f7b06a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #4547   +/-   ##
========================================
  Coverage          ?   6.64%           
========================================
  Files             ?     715           
  Lines             ?   95327           
  Branches          ?       0           
========================================
  Hits              ?    6336           
  Misses            ?   88558           
  Partials          ?     433
Flag Coverage Δ
#e2e 6.64% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7b06a...761f885. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #4547 into master will increase coverage by 37.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4547       +/-   ##
===========================================
+ Coverage    6.39%   43.54%   +37.14%     
===========================================
  Files         715      838      +123     
  Lines       95327   106187    +10860     
===========================================
+ Hits         6096    46234    +40138     
+ Misses      88834    55905    -32929     
- Partials      397     4048     +3651
Flag Coverage Δ
#e2e 30.31% <ø> (+23.91%) ⬆️
#integration 41.93% <ø> (?)
Impacted Files Coverage Δ
cmd/codegen/app/generate_openapi.go 0% <0%> (ø)
pkg/client/informers/externalversions/factory.go 0% <0%> (ø)
...informers/externalversions/jenkins.io/interface.go 0% <0%> (ø)
...xternalversions/jenkins.io/v1/pipelinestructure.go 0% <0%> (ø)
pkg/tests/retry.go 68.96% <0%> (ø)
cmd/codegen/util/strings.go 100% <0%> (ø)
pkg/jenkins/fake/fake_jenkins.go 41.22% <0%> (ø)
...ks/matchers/slice_of_ptr_to_gits_gitpullrequest.go 0% <0%> (ø)
pkg/client/informers/externalversions/generic.go 0% <0%> (ø)
pkg/client/listers/jenkins.io/v1/user.go 0% <0%> (ø)
... and 434 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7b06a...761f885. Read the comment docs.

@cagiti
Copy link
Contributor

cagiti commented Jul 2, 2019

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cagiti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abayer
Copy link
Contributor Author

abayer commented Jul 2, 2019

/hold

Holding so #4529 can get merged without batch hell.

@rawlingsj
Copy link
Member

Holding so #4529 can get merged without batch hell.
🙏

@rawlingsj
Copy link
Member

/override codecov/project
/hold cancel

@jenkins-x-bot
Copy link
Contributor

@rawlingsj: Overrode contexts on behalf of rawlingsj: codecov/project

In response to this:

/override codecov/project
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rawlingsj
Copy link
Member

/hold cancel

@abayer
Copy link
Contributor Author

abayer commented Jul 3, 2019

/test integration

@jenkins-x-bot jenkins-x-bot merged commit 6163a9f into jenkins-x:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants