Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

step git merge only displays the help message #4334

Closed
hferentschik opened this issue Jun 19, 2019 · 1 comment
Closed

step git merge only displays the help message #4334

hferentschik opened this issue Jun 19, 2019 · 1 comment
Assignees
@hferentschik
Labels
kind/bug Issue is a bug priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@hferentschik
Copy link

Summary

Currently executing jx step git merge will only display the help message, no matter what arguments are passed or whether the PULL_REFS env variable is set.

This is due to a wrong setup of the StepGitMergeOptions struct.

Steps to reproduce the behavior

Run:

jx step git merge
@hferentschik hferentschik self-assigned this Jun 19, 2019
@hferentschik hferentschik added kind/bug Issue is a bug priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jun 19, 2019
hferentschik added a commit to hferentschik/jx that referenced this issue Jun 19, 2019
@hferentschik
fix: making sure the right Run function is called for step git merge
f5c7d0e 
fixes issue jenkins-x#4334

Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
hferentschik added a commit to hferentschik/jx that referenced this issue Jun 19, 2019
@hferentschik
fix: making sure the right Run function is called for step git merge
2590248 
fixes issue jenkins-x#4334

Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
hferentschik added a commit to hferentschik/jx that referenced this issue Jun 19, 2019
@hferentschik
fix: making sure the right Run function is called for step git merge
b681cba 
fixes issue jenkins-x#4334

Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
@hferentschik hferentschik mentioned this issue Jun 19, 2019
Merged
jenkins-x-bot pushed a commit that referenced this issue Jun 19, 2019
@hferentschik @jenkins-x-bot
fix: making sure the right Run function is called for step git merge (#…
442ddfc 
…4336)

fixes issue #4334

Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
@hferentschik
Copy link
Author

fixed by pull request #4336

@hferentschik hferentschik mentioned this issue Jun 20, 2019
Closed
daveconde pushed a commit to daveconde/jx that referenced this issue Apr 7, 2020
@hferentschik
fix: making sure the right Run function is called for step git merge (j…
0cd1016 
…enkins-x#4336)

fixes issue jenkins-x#4334

Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hferentschik hferentschik

Labels
kind/bug Issue is a bug priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hferentschik