Make Environment Controller work with private repo

[tanya-sy]

Summary

Environmental controller doesn't manage to setup builds of private repos

Steps to reproduce the behavior

Make the repo private.

Create an environmental controller using the instructions here https://jenkins-x.io/getting-started/multi-cluster/#installing-environment-controller

jx create addon envctl -s https://github.com/myorg/env-production.git --project-id myproject --docker-registry gcr.io --cluster-rbac true --user mygituser --token mygittoken

Expected behavior

The build succeeeds.

Actual behavior

"level":"error","ts":1602752044.3771713,"logger":"fallback-logger","caller":"git/git.go:40","msg":"Error running git [fetch --depth=1 --recurse-submodules=yes origin v0.0.9]: exit status 128\nfatal: could not read Username for 'https://github.com': No such device or address\n","stacktrace":"github.com/tektoncd/pipeline/pkg/git.run\n\t/Users/abayer/go/src/github.com/tektoncd/pipeline/pkg/git/git.go:40\ngithub.com/tektoncd/pipeline/pkg/git.Fetch\n\t/Users/abayer/go/src/github.com/tektoncd/pipeline/pkg/git/git.go:91\nmain.main\n\t/Users/abayer/go/src/github.com/tektoncd/pipeline/cmd/git-init/main.go:39\nruntime.main\n\t/usr/local/Cellar/go@1.12/1.12.17/libexec/src/runtime/proc.go:200"}

Jx version

The output of jx version is:

NAME               VERSION
jx                 2.1.62-dev+6e796652f
Kubernetes cluster v1.16.13-eks-2ba888
kubectl            v1.16.8-eks-e16311
helm client        2.16.9
git                1.8.3.1
Operating System   Unknown Linux distribution Linux version 3.10.0-957.5.1.el7.x86_64 (mockbuild@kbuilder.bsys.centos.org) (gcc version 4.8.5 20150623 (Red Hat 4.8.5-36) (GCC) ) #1 SMP Fri Feb 1 14:54:57 UTC 2019

[jenkins-x-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

[jenkins-x-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten